feat: add AbortIncompleteMultipartUpload lifecycle rule#765
Merged
gcf-merge-on-green[bot] merged 6 commits intomainfrom Apr 15, 2022
Merged
feat: add AbortIncompleteMultipartUpload lifecycle rule#765gcf-merge-on-green[bot] merged 6 commits intomainfrom
gcf-merge-on-green[bot] merged 6 commits intomainfrom
Conversation
cojenco
reviewed
Apr 13, 2022
cojenco
reviewed
Apr 13, 2022
cojenco
reviewed
Apr 13, 2022
Contributor
cojenco
left a comment
There was a problem hiding this comment.
Looks good, thanks for working on this! I'll be adding the prefix/suffix support on top of this :)
cojenco
reviewed
Apr 15, 2022
tests/system/test_bucket.py
Outdated
| bucket.lifecycle_rules = rules | ||
| bucket.patch() | ||
|
|
||
| bucket.reload() |
Contributor
There was a problem hiding this comment.
Curious do we need to reload the bucket here, same on L111? The patch call should return the bucket metadata? Otherwise, LGTM, thanks!
Contributor
Author
There was a problem hiding this comment.
No, you're right, we should be able to skip that. I'll remove them and confirm it still works.
cojenco
approved these changes
Apr 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #753 🦕