xds: Rename ring_hash LB Policy to ring_hash_experimental#8776
Merged
sergiitk merged 2 commits intogrpc:masterfrom Jan 7, 2022
Merged
xds: Rename ring_hash LB Policy to ring_hash_experimental#8776sergiitk merged 2 commits intogrpc:masterfrom
sergiitk merged 2 commits intogrpc:masterfrom
Conversation
Ring hash can only be used from within xds currently, because that's the only way to get a hash assigned to RPCs which is required for it to function. So it should be using the _experimental suffix like the other only-used-from-xds policies. Fixes grpc#8756
Member
Author
|
Not sure if we need to rename grpc-java/xds/src/main/java/io/grpc/xds/RingHashLoadBalancer.java Lines 71 to 76 in 0245a72 |
Member
Author
|
@ejona86 friendly ping |
ejona86
approved these changes
Jan 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ring hash can only be used from within xds currently, because that's
the only way to get a hash assigned to RPCs which is required for it
to function. So it should be using the _experimental suffix like the
other only-used-from-xds policies.
Fixes #8756