Skip to content

xds: Allow unspecified listener traffic direction to work with Istio#9173

Merged
sanjaypujare merged 3 commits into
grpc:masterfrom
cfredri4:patch-1
May 16, 2022
Merged

xds: Allow unspecified listener traffic direction to work with Istio#9173
sanjaypujare merged 3 commits into
grpc:masterfrom
cfredri4:patch-1

Conversation

@cfredri4

@cfredri4 cfredri4 commented May 14, 2022

Copy link
Copy Markdown
Contributor

Fix for #9157.

Ping @sanjaypujare

@cfredri4 cfredri4 changed the title Allow unspecified listener traffic direction to work with Istio xds: Allow unspecified listener traffic direction to work with Istio May 14, 2022
@sanjaypujare sanjaypujare added the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label May 15, 2022
@grpc-kokoro grpc-kokoro removed the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label May 15, 2022
@sanjaypujare

sanjaypujare commented May 15, 2022

Copy link
Copy Markdown
Contributor

@yashykt @easwars I think C++ and Go don't have the check so they accept LDS even if the direction is unspecified. Is that correct?

sanjaypujare
sanjaypujare approved these changes May 15, 2022
View reviewed changes

@sanjaypujare sanjaypujare left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easwars

easwars commented May 16, 2022

Copy link
Copy Markdown

@yashykt @easwars I think C++ and Go don't have the check so they accept LDS even if the direction is unspecified. Is that correct?

Yes, grpc-go does not have a check for the TrafficDirection field.

@sanjaypujare sanjaypujare merged commit 1d4e82e into grpc:master May 16, 2022
@sanjaypujare sanjaypujare mentioned this pull request May 17, 2022
Closed
@yashykt

yashykt commented May 17, 2022

Copy link
Copy Markdown
Member

Core/C++ does not make any check on traffic direction

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@sanjaypujare sanjaypujare sanjaypujare approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cfredri4 @sanjaypujare @easwars @yashykt @grpc-kokoro