Skip to content

/ platform-samples

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Branch Scanning #258

Open
wants to merge 9 commits into
base: master
from
Open

Add Branch Scanning #258

wants to merge 9 commits into from
+43 −12

Conversation

@JennieOhyoung
Copy link

JennieOhyoung commented Jul 23, 2019

I made some changes to this script because:

  1. The commit check is only looking at the default branch and not checking other branches. I added the '-b' option to enable branch scanning.
  2. Some customers are unsure how to get started, so I added a doc link on how to generate a token and specified the date format.
@JennieOhyoung
add -b tag to iterate through branches
06e4aaa
@JennieOhyoung
updated readme with details around -b
d7168f0
@JennieOhyoung
Remove accidentally committed temporary files
9cdcf3b
@JennieOhyoung
Adding date format
37a91ad
@JennieOhyoung
Reformatting README.md
f9e5dc2
@JennieOhyoung
Modified README.md
2bee1bd
@JennieOhyoung
Copy link
Author

JennieOhyoung commented Jul 23, 2019

Note: please allow me to do the merging after review. I have a customer currently using the script off of this branch.
@JennieOhyoung JennieOhyoung requested review from azizshamim and pholleran Jul 23, 2019
@primetheus
Copy link
Contributor

primetheus commented Jul 25, 2019

@JennieOhyoung this is really great! Can you update it to use spaces instead of tabs? The formatting of the additions makes some of the additions a bit hard to follow 🙏 🙇
@primetheus
primetheus requested changes Jul 25, 2019
View changes
Copy link
Contributor

primetheus left a comment

the suggested changes feature only allows one line at a time, but lines 119-145, as well as 266-269 have formatting issues as well. Might be a bit of a nit-pick, but helps with the readability when it's all formatted the same 🙇
api/ruby/find-inactive-members/find_inactive_members.rb Outdated Show resolved Hide resolved
@JennieOhyoung @primetheus
Update api/ruby/find-inactive-members/find_inactive_members.rb
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
3a0819a 
Co-Authored-By: Jared Murrell <primetheus@github.com>
@github github deleted a comment from Aa88s Aug 12, 2019
@jonico
Merge branch 'master' into feature_check_branch_commits
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a29aad7
@jonico
jonico reviewed Mar 20, 2020
View changes
api/ruby/find-inactive-members/find_inactive_members.rb
end
# Get all the branches so we can loop through them
if @branches
@client.branches(repo).each do |branch|

This comment has been minimized.

Sign in to view
@jonico

jonico Mar 20, 2020 Contributor

@JennieOhyoung: looks as if indenting is broken here
@primetheus
primetheus reviewed Mar 20, 2020
View changes
api/ruby/find-inactive-members/find_inactive_members.rb Outdated Show resolved Hide resolved
@primetheus primetheus dismissed their stale review Mar 20, 2020

misread notification

@primetheus
Update api/ruby/find-inactive-members/find_inactive_members.rb
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
861ff72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonico jonico

@primetheus primetheus

@azizshamim azizshamim

@pholleran pholleran

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@JennieOhyoung @primetheus @jonico
You can’t perform that action at this time.