github / platform-samples

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated require-jira-issue.sh #295

Open

sandeeprayala wants to merge 1 commit into github:master from sandeeprayala:patch-2

sandeeprayala commented Feb 11, 2020 •

edited

'-' is a special character in regex when you use inside character class [], it stands for range when it appears anywhere else except

As the first character in class or after [^]
At the end of character class
so your regex should be -- 'JIRA-[0-9]+'


        Updated require-jira-issue.sh

0bec38e

- is a special character in regex when you use inside character class [], it stands for range when it appears anywhere else except

As the first character in class or after [^]
At the end of character class
so your regex should be -- 'JIRA-[0-9]+'

sandeeprayala requested review from larsxschneider and pravipati

jonico requested changes

pre-receive-hooks/require-jira-issue.sh

  
      @@ -15,7 +15,7 @@
    
        set -e

        zero_commit='0000000000000000000000000000000000000000'

        msg_regex='[JIRA\-[0-9]+\]'

jonico Mar 20, 2020 Contributor

@sandeeprayala: as you noticed, minus is a special character, so we escaped it to match it as a literal. Your suggested change is to remove that escaping. Have you tested your change? Are you saying that the script did not work for you before?

sandeeprayala Apr 21, 2020 Author

Yes, I have tested and it worked for me, my suggestion is to remove the " [ ] "'.

once you remove the square brackets the regex would be as below.
msg_regex= 'JIRA-[0-9]+'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.