fix(bazel): fix integration test for bazel building #38629
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
approved these changes
Aug 28, 2020
LGTM since the test now passes but can you update the commit message to be a bit more descriptive about why this change was made? It currently just says "what" the change is but not "why" it was necessary.
Update the API used to request a timestamp. The previous API we relied on for this test application, worldclockapi.com no longer serves times and simply 403s on all requests. This caused our test to timeout as the HTTP request did not handle a failure case. By moving to a new api, the HTTP request responds as expected and timeouts are corrected as there is not longer a pending microtask in the queue.
devversion
reviewed
Aug 28, 2020
| @@ -15,6 +15,6 @@ export class AppComponent { | |||
| constructor(private http: HttpClient) {} | |||
|
|
|||
| time$: Observable<string> = | |||
| this.http.get('http://worldclockapi.com/api/json/pst/now') | |||
| .pipe(map((result: any) => result.currentDateTime), startWith(['...'])); | |||
| this.http.get('http://worldtimeapi.org/api/timezone/America/Los_Angeles.json') | |||
There was a problem hiding this comment.
Out of curiosity: Should we just change this away from an external server? I don't see why we'd need to rely on an external server here? Especially as that can impact our stability.
There was a problem hiding this comment.
Yes, my plan was to investigate further to determine if we need this at all, but wanted to get CI fixed first.
There was a problem hiding this comment.
I see, nice catch by the way
josephperrott
added a commit
that referenced
this issue
Aug 28, 2020
Update the API used to request a timestamp. The previous API we relied on for this test application, worldclockapi.com no longer serves times and simply 403s on all requests. This caused our test to timeout as the HTTP request did not handle a failure case. By moving to a new api, the HTTP request responds as expected and timeouts are corrected as there is not longer a pending microtask in the queue. PR Close #38629
josephperrott
added a commit
that referenced
this issue
Aug 28, 2020
Update the API used to request a timestamp. The previous API we relied on for this test application, worldclockapi.com no longer serves times and simply 403s on all requests. This caused our test to timeout as the HTTP request did not handle a failure case. By moving to a new api, the HTTP request responds as expected and timeouts are corrected as there is not longer a pending microtask in the queue. PR Close #38629
subratpalhar92
added a commit
to SUBRATPALHAR-ALL-JAVASCRIPT/angular
that referenced
this issue
Aug 29, 2020
Update the API used to request a timestamp. The previous API we relied on for this test application, worldclockapi.com no longer serves times and simply 403s on all requests. This caused our test to timeout as the HTTP request did not handle a failure case. By moving to a new api, the HTTP request responds as expected and timeouts are corrected as there is not longer a pending microtask in the queue. PR Close angular#38629
subratpalhar92
added a commit
to SUBRATPALHAR-ALL-JAVASCRIPT/angular
that referenced
this issue
Aug 31, 2020
subratpalhar92
added a commit
to SUBRATPALHAR-ALL-JAVASCRIPT/angular
that referenced
this issue
Aug 31, 2020
Update the API used to request a timestamp. The previous API we relied on for this test application, worldclockapi.com no longer serves times and simply 403s on all requests. This caused our test to timeout as the HTTP request did not handle a failure case. By moving to a new api, the HTTP request responds as expected and timeouts are corrected as there is not longer a pending microtask in the queue. PR Close angular#38629
profanis
added a commit
to profanis/angular
that referenced
this issue
Sep 5, 2020
Update the API used to request a timestamp. The previous API we relied on for this test application, worldclockapi.com no longer serves times and simply 403s on all requests. This caused our test to timeout as the HTTP request did not handle a failure case. By moving to a new api, the HTTP request responds as expected and timeouts are corrected as there is not longer a pending microtask in the queue. PR Close angular#38629
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Update the API used to request a timestamp.