Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serilog.dll can conflict with other plugins using Serilog in Visual Studio #2535

Open
IvoMiller opened this issue Aug 6, 2020 · 1 comment
Open

Comments

@IvoMiller
Copy link

@IvoMiller IvoMiller commented Aug 6, 2020

If multiple Visual Studio plugins use serilog for logging, this can cause conflicts.
For example this happens when Red Gate plugins such as SQL Change Automation are installed alongside GitHub Extension for Visual Studio.
This probably isn't something that can be solved in this plugin, but it would be less of an issue if this plugin were using the latest version of Serilog (it currently uses 2.5.0 and the latest is 2.7.1) and could keep it regularly updated

Versions

  • GitHub Extension for Visual Studio version: Any
  • Visual Studio version: 2019

What happened

Errors when opening a SQL Change Automation project (note that this problem is almost certainly not limited to this plugin alone).

Steps to Reproduce

This can be reproduced by installing Red Gate SQL Change Automation alongside GitHub Extension for Visual Studio, and opening/creating a SQL Change Automation project.
A reproduction shouldn't really be necessary here though.

Expected behavior

These plugins ideally shouldn't collide in any way

Screenshots

Not immediately available. Can be supplied if necessary.

Logs

Not immediately available. Can be supplied if necessary.

Additional context

@yuakihiro
Copy link

@yuakihiro yuakihiro commented Aug 11, 2020

Serilog.Sinks.File is conflicting with BuildVision or other Extension
serilog/serilog-sinks-file#159
StefanKert/BuildVision#97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.