Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing formatting in Reset-PWSHSystemPath.ps1 #13689

Merged
merged 1 commit into from Nov 25, 2020

Conversation

dgoldman-msft
Copy link
Contributor

@dgoldman-msft dgoldman-msft commented Sep 24, 2020

Fixed examples

During a code review I found a formatting issue with two examples

Opened a PR to have formatting issues fixed

PR Checklist

Fixed examples
@iSazonov iSazonov added the CL-Tools label Sep 29, 2020
@msftbot msftbot bot added the Review - Needed label Oct 6, 2020
@msftbot
Copy link

@msftbot msftbot bot commented Oct 6, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Oct 13, 2020

Re-running failing CI.

@msftbot msftbot bot removed the Review - Needed label Oct 13, 2020
@msftbot msftbot bot added the Review - Needed label Oct 21, 2020
@msftbot
Copy link

@msftbot msftbot bot commented Oct 21, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Nov 4, 2020

Re-running tests again.

@msftbot msftbot bot removed the Review - Needed label Nov 4, 2020
@msftbot msftbot bot added the Review - Needed label Nov 12, 2020
@msftbot
Copy link

@msftbot msftbot bot commented Nov 12, 2020

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov closed this Nov 25, 2020
@msftbot msftbot bot removed the Review - Needed label Nov 25, 2020
@iSazonov iSazonov reopened this Nov 25, 2020
@iSazonov iSazonov merged commit bb4a0f4 into PowerShell:master Nov 25, 2020
33 checks passed
@iSazonov
Copy link
Collaborator

@iSazonov iSazonov commented Nov 25, 2020

@dgoldman-msft Thanks for your contribution!

@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Nov 25, 2020
@iSazonov iSazonov changed the title Fixing Formatting in Reset-PWSHSystemPath.ps1 Fixing formatting in Reset-PWSHSystemPath.ps1 Nov 25, 2020
@msftbot
Copy link

@msftbot msftbot bot commented Dec 15, 2020

🎉v7.2.0-preview.2 has been released which incorporates this pull request.🎉

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants