This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Extract dummy files for errors without locations #526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abd44d4 to
7458f89
Compare
smowton
approved these changes
Apr 21, 2021
Contributor
smowton
left a comment
There was a problem hiding this comment.
LGTM dist build is good, happy to merge if the dist-compare is also clean
These previously produced malformed TRAP. I have checked the other uses of GlobalID and don't see any others that should require escaping.
7458f89 to
b808c18
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how the other languages do this, but this fixes the issue for now.