feat: reuse instance connection managers#69
Merged
Merged
Conversation
kurtisvg
approved these changes
Apr 2, 2021
| :param instance_connection_string: | ||
| :type instance_conn_str: str | ||
| :param instance_conn_str: | ||
| A string containing the GCP project name, region name, and instance |
Contributor
There was a problem hiding this comment.
If you're going to shorten this, update the docstring to include "instance connection string" and an explanation of the format, since that's a significant term in helping users find it in the console.
|
|
||
|
|
||
| def connect(instance_connection_string, driver: str, **kwargs): | ||
| def connect(instance_conn_str, driver: str, **kwargs): |
Contributor
There was a problem hiding this comment.
nit: if you're gonna shorten, shorten consistently
Suggested change
| def connect(instance_conn_str, driver: str, **kwargs): | |
| def connect(inst_conn_str, driver: str, **kwargs): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #64