Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

fix: use proper scope for DirectPath transitive dependencies#59

Merged
igorbernstein2 merged 1 commit into
googleapis:masterfrom
igorbernstein2:dp-fixes
Nov 1, 2019
Merged

fix: use proper scope for DirectPath transitive dependencies#59
igorbernstein2 merged 1 commit into
googleapis:masterfrom
igorbernstein2:dp-fixes

Conversation

@igorbernstein2

Copy link
Copy Markdown
Contributor

grpc-alts has a transitive dep on grpc-stub, but our tests have a direct dependency on it. This would cause the transitive dependency to be downgraded to the test scope

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 1, 2019
@igorbernstein2 igorbernstein2 requested a review from kolea2 November 1, 2019 15:48
@codecov

codecov Bot commented Nov 1, 2019

Copy link
Copy Markdown

Codecov Report

Merging #59 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #59   +/-   ##
=========================================
  Coverage     81.29%   81.29%           
  Complexity      937      937           
=========================================
  Files            95       95           
  Lines          5842     5842           
  Branches        325      325           
=========================================
  Hits           4749     4749           
  Misses          917      917           
  Partials        176      176

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 846a44f...a65973a. Read the comment docs.

@igorbernstein2 igorbernstein2 merged commit 1d1c4de into googleapis:master Nov 1, 2019
@igorbernstein2 igorbernstein2 deleted the dp-fixes branch November 1, 2019 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants