Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

fix: exclude protobuf from conformance-tests#845

Merged
mutianf merged 2 commits into
googleapis:masterfrom
mutianf:version
May 27, 2021
Merged

fix: exclude protobuf from conformance-tests#845
mutianf merged 2 commits into
googleapis:masterfrom
mutianf:version

Conversation

@mutianf

@mutianf mutianf commented May 27, 2021

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@mutianf mutianf requested review from a team May 27, 2021 18:52
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label May 27, 2021
@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label May 27, 2021
@mutianf mutianf requested a review from igorbernstein2 May 27, 2021 19:42
igorbernstein2
igorbernstein2 approved these changes May 27, 2021
View reviewed changes

@igorbernstein2 igorbernstein2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mutianf mutianf merged commit 1d89191 into googleapis:master May 27, 2021
@mutianf mutianf deleted the version branch May 27, 2021 20:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mutianf @igorbernstein2