Skip to content

Add Tiny AE live preview#10365

Merged
AUTOMATIC1111 merged 7 commits into
AUTOMATIC1111:devfrom
Sakura-Luna:taesd-a
May 17, 2023
Merged

Add Tiny AE live preview#10365
AUTOMATIC1111 merged 7 commits into
AUTOMATIC1111:devfrom
Sakura-Luna:taesd-a

Conversation

@Sakura-Luna

@Sakura-Luna Sakura-Luna commented May 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Added Tiny AE for better live preview.

Here's an example, output and approximation:
拷贝

Most of the work is done, but there are still some issues:

  1. The effect is slightly worse than the original repository's example (color difference), and I don't know if it can be improved.
  2. It seems that some details need to be improved.
  3. Since its effect and performance are very good, I think Approx NN can be removed.

@Sakura-Luna

Sakura-Luna commented May 14, 2023

Copy link
Copy Markdown
Collaborator Author

@AUTOMATIC1111 What do you think about it?

@Sakura-Luna

Sakura-Luna commented May 14, 2023

Copy link
Copy Markdown
Collaborator Author

The simple test takes time, Approx is about 0.003s, and Tiny is about 0.016s, which has little effect on the speed.

@papuSpartan

papuSpartan commented May 14, 2023

Copy link
Copy Markdown
Contributor

Probably should be based against dev branch?

@Sakura-Luna

Sakura-Luna commented May 14, 2023

Copy link
Copy Markdown
Collaborator Author

Probably should be based against dev branch?

They're not very different, and it's not a priority yet.

EfourC
EfourC reviewed May 14, 2023
View reviewed changes
Comment thread modules/sd_samplers_common.py Outdated
catboxanon
catboxanon reviewed May 14, 2023
View reviewed changes
Comment thread webui.py Outdated
Comment thread modules/sd_vae_taesd.py Outdated
@Sakura-Luna Sakura-Luna marked this pull request as ready for review May 15, 2023 04:40
Sakura-Luna and others added 3 commits May 17, 2023 00:32
@Sakura-Luna
Minor change
4fb2cc0
@AUTOMATIC1111
add credits
b217ebc
@AUTOMATIC1111
return live preview defaults to how they were
56a2672 
only download TAESD model when it's needed
return calculations in single_sample_to_image to just if/elif/elif blocks
keep taesd model in its own directory
@AUTOMATIC1111 AUTOMATIC1111 changed the base branch from master to dev May 17, 2023 06:24
@AUTOMATIC1111 AUTOMATIC1111 merged commit 9ac85b8 into AUTOMATIC1111:dev May 17, 2023
@Sakura-Luna Sakura-Luna mentioned this pull request May 17, 2023
Merged
ZyCromerZ added a commit to ZyCromerZ/automatic that referenced this pull request May 28, 2023
@ZyCromerZ
add TAESD from AUTOMATIC1111/stable-diffusion-webui#10365
ce650d5 
Signed-off-by: ZyCromerZ <neetroid97@gmail.com>
ZyCromerZ added a commit to ZyCromerZ/automatic that referenced this pull request May 28, 2023
@ZyCromerZ
add TAESD from AUTOMATIC1111/stable-diffusion-webui#10365
f1ae1b2 
Signed-off-by: ZyCromerZ <neetroid97@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@catboxanon catboxanon catboxanon left review comments
@AUTOMATIC1111 AUTOMATIC1111 AUTOMATIC1111 approved these changes
+1 more reviewer
@EfourC EfourC EfourC left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Sakura-Luna @papuSpartan @AUTOMATIC1111 @EfourC @catboxanon