Skip to content

Move global declarations into a namespace for 'amap-js-api'.#34454

Merged
DanielRosenwasser merged 1 commit into
DefinitelyTyped:masterfrom
DanielRosenwasser:deglobalizeOmit
Apr 4, 2019
Merged

Move global declarations into a namespace for 'amap-js-api'.#34454
DanielRosenwasser merged 1 commit into
DefinitelyTyped:masterfrom
DanielRosenwasser:deglobalizeOmit

Conversation

@DanielRosenwasser

@DanielRosenwasser DanielRosenwasser commented Apr 3, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

These types pollute the global namespace, and conflict with the upcoming Omit type helper coming to TypeScript 3.5.

Related to microsoft/TypeScript#30552

@DanielRosenwasser DanielRosenwasser mentioned this pull request Apr 3, 2019
Merged
@typescript-bot

typescript-bot commented Apr 3, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

@DanielRosenwasser Thank you for submitting this PR!

🔔 @breeze9527 - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot

typescript-bot commented Apr 3, 2019

Copy link
Copy Markdown
Contributor

@DanielRosenwasser The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Apr 4, 2019
@typescript-bot

typescript-bot commented Apr 4, 2019

Copy link
Copy Markdown
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

breeze9527 added a commit to breeze9527/amap-js-api-workspace that referenced this pull request Apr 4, 2019
@breeze9527
Avoid global pollution, see DefinitelyTyped/DefinitelyTyped#34454
dff2795
@DanielRosenwasser DanielRosenwasser merged commit 20caac7 into DefinitelyTyped:master Apr 4, 2019
@DanielRosenwasser

DanielRosenwasser commented Apr 4, 2019

Copy link
Copy Markdown
Member Author

Thanks for the review!

@DanielRosenwasser DanielRosenwasser deleted the deglobalizeOmit branch April 4, 2019 16:57
@typescript-bot

typescript-bot commented Apr 4, 2019

Copy link
Copy Markdown
Contributor

I just published @types/amap-js-api@1.4.3 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@breeze9527 breeze9527 breeze9527 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Owner Approved A listed owner of this package signed off on the pull request.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DanielRosenwasser @typescript-bot @breeze9527