Skip to content

Enhancement: Dynamic dark mode#1028

Merged
mohdsayed merged 5 commits into
developfrom
enhancement/dynamic-dark-mode
Apr 3, 2025
Merged

Enhancement: Dynamic dark mode#1028
mohdsayed merged 5 commits into
developfrom
enhancement/dynamic-dark-mode

Conversation

@CharliePops

@CharliePops CharliePops commented Apr 3, 2025

Copy link
Copy Markdown
Contributor

Description

Apply dynamic dark/light mode when changing broswer's appearance theme

Testing Instructions

  1. Pull and checkout the branch enhancement/dynamic-dark-mode
  2. Build and run the extension: npm run build:all && npm run dev:ext
  3. Open Privacy Sandbox tab on DevTools
  4. Go tochrome://settings/appearance
  5. Select a different appearance theme mode
  6. Observe: the PSAT extension swaps theme mode automatically

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@CharliePops CharliePops added this to the Future Releases milestone Apr 3, 2025
@CharliePops CharliePops self-assigned this Apr 3, 2025
@mohdsayed mohdsayed merged commit 65957ec into develop Apr 3, 2025
@mohdsayed mohdsayed deleted the enhancement/dynamic-dark-mode branch April 3, 2025 12:24
@mohdsayed mohdsayed modified the milestones: Future Releases, v0.13.1 Apr 8, 2025
mohdsayed pushed a commit that referenced this pull request Apr 8, 2025
* set theme mode dynamically

* fix dark/light mode in jsonview

* remove console.log

* fix broken test

* improve theme mode set logic
@mohdsayed mohdsayed mentioned this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants