Misc QA Fixes#1043
Merged
Merged
Conversation
* make json view collapsible and replace third party library * improve colors and fix dark mode * rename json theme file * fix import statement * fix puppeter and worker.js * expand only root object in json view * improve dark light color matching * further improve styles to match default devtools styling * Reduce the size of three dots in collapsed state * center loading text and center collapse/expand icons --------- Co-authored-by: sayedtaqui <sayedwp@gmail.com>
* set theme mode dynamically * fix dark/light mode in jsonview * remove console.log * fix broken test * improve theme mode set logic
mohdsayed
approved these changes
Apr 14, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Relevant Technical Choices
Testing Instructions
Additional Information:
Screenshot/Screencast
Checklist
- [ ] This code is covered by unit tests to verify that it works as intended.