Fix: Extension breakage due to global variable conflict#1132
Merged
Conversation
mohdsayed
approved these changes
Jul 30, 2025
Merged
mohdsayed
added a commit
that referenced
this pull request
Aug 27, 2025
* Fix: Extension breakage due to global variable conflict (#1132) * Refactor minification logic in script configuration * Simplify minification logic in createScriptConfig function * Update cookie database, rws and changelog * Bump version * Fix vulnerabilities * Remove soft hypen --------- Co-authored-by: Kudaligi Amoghavarsha <kgamoghavarsha@gmail.com>
mohdsayed
added a commit
that referenced
this pull request
Aug 28, 2025
* Fix: Extension breakage due to global variable conflict (#1132) * Refactor minification logic in script configuration * Simplify minification logic in createScriptConfig function * Update cookie database, rws and changelog * Bump version * Fix vulnerabilities * Remove soft hypen * Chore(deps): Bump mermaid from 11.6.0 to 11.10.0 (#1136) * Chore(deps): Bump mermaid from 11.6.0 to 11.10.0 Bumps [mermaid](https://github.com/mermaid-js/mermaid) from 11.6.0 to 11.10.0. - [Release notes](https://github.com/mermaid-js/mermaid/releases) - [Commits](https://github.com/mermaid-js/mermaid/compare/mermaid@11.6.0...mermaid@11.10.0) --- updated-dependencies: - dependency-name: mermaid dependency-version: 11.10.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Upgrade p5 * Ignore ts issue --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sayedtaqui <sayedwp@gmail.com> * Chore(deps-dev): Bump vite-plugin-static-copy from 3.0.2 to 3.1.2 (#1137) Bumps [vite-plugin-static-copy](https://github.com/sapphi-red/vite-plugin-static-copy) from 3.0.2 to 3.1.2. - [Release notes](https://github.com/sapphi-red/vite-plugin-static-copy/releases) - [Changelog](https://github.com/sapphi-red/vite-plugin-static-copy/blob/main/CHANGELOG.md) - [Commits](https://github.com/sapphi-red/vite-plugin-static-copy/compare/vite-plugin-static-copy@3.0.2...vite-plugin-static-copy@3.1.2) --- updated-dependencies: - dependency-name: vite-plugin-static-copy dependency-version: 3.1.2 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: sayedtaqui <sayedwp@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kudaligi Amoghavarsha <kgamoghavarsha@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a critical issue where certain pages fail to load due to global variable collisions, specifically with the
neidentifier. The problem was traced to a conflict between pages and extensions, which was exacerbated by recent changes in Vite configuration. This collision was causing an error related to the re-declaration of theneidentifier.Relevant Technical Choices
target: 'esnext'to the configuration to prevent the unintended injection of global variables. This ensures that the build output is compatible with the latest JavaScript features and avoids conflicts.Testing Instructions
neidentifier or global variable collisions.Additional Information:
This fix is a one-line change that targets the core of the problem by adjusting the build configuration. It's a targeted and efficient solution to a critical bug.
Screenshot/Screencast
(Please provide a screenshot or screencast of the page loading successfully after the fix is implemented.)
Checklist