Added the option to set custom credentials scopes #1381
Conversation
|
/gcbrun |
There was a problem hiding this comment.
Summary of Changes
Hello @davidrabinowitz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request adds the capability for users to define custom OAuth 2.0 scopes for the Google Cloud credentials used by the BigQuery connector. This provides more granular control over the permissions granted to the connector, enhancing security and flexibility. The changes involve updating configuration classes, the credentials supplier logic, and adding corresponding tests.
Highlights
- Custom Credentials Scopes: Introduced a new configuration option (
credentialsScopes) to allow users to specify custom OAuth 2.0 scopes when creating Google Cloud credentials for the BigQuery connector. - Credentials Supplier Update: Modified the
BigQueryCredentialsSupplierto accept and apply the specified custom scopes to the generatedGoogleCredentialsobject using thecreateScopedmethod. - Configuration Integration: Integrated the new
credentialsScopesoption into the common BigQuery configuration (BigQueryConfig,BigQueryClientFactoryConfig) and the Spark-specific configuration (SparkBigQueryConfig), including parsing comma-separated scope strings in the Spark connector. - List Handling Refactor: Refactored the handling of list-like configuration options (
clusteredFields,decimalTargetTypes) inSparkBigQueryConfigto useImmutableList<String>and a common helper method for splitting comma-separated strings. - Testing: Added unit tests to verify that custom scopes are correctly applied to the generated credentials.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces the capability to set custom credentials scopes. The changes are well-integrated into the existing configuration and credential supply mechanisms. Tests have been updated and a new test case validates the core feature. A minor improvement is suggested for the splitOnComma helper method in SparkBigQueryConfig.java to make it more robust against empty strings in comma-separated lists, which could affect credentialsScopes, clusteredFields, and decimalTargetTypes.
...uery-connector-common/src/main/java/com/google/cloud/spark/bigquery/SparkBigQueryConfig.java
Show resolved
Hide resolved
|
/gcbrun |
|
/gcbrun |
No description provided.