Skip to content
This repository was archived by the owner on May 16, 2025. It is now read-only.

Q3 master release#825

Merged
ivannaranjo merged 2 commits intomasterfrom
q3_master_release
Oct 10, 2017
Merged

Q3 master release#825
ivannaranjo merged 2 commits intomasterfrom
q3_master_release

Conversation

@ivannaranjo
Copy link
Contributor

Bringing changes from the q3_master_release branch into the master branch.

Jim Przybylinski and others added 2 commits October 4, 2017 10:26
Make MVC the default for the new template dialog box.
Change the Template Chooser Window Margins to match the Microsoft UX Style Guide.
* Updating the extension version to 1.2.10.0

* Udpating the minimuim requirement to version 174 of the Cloud SDK.
@ivannaranjo ivannaranjo requested a review from ILMTitan October 6, 2017 13:55
@codecov
Copy link

codecov bot commented Oct 6, 2017

Codecov Report

Merging #825 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #825   +/-   ##
=======================================
  Coverage   11.97%   11.97%           
=======================================
  Files         505      505           
  Lines       12331    12331           
=======================================
  Hits         1477     1477           
  Misses      10854    10854
Impacted Files Coverage Δ
...ateChooserDialog/TemplateChooserWindowContent.xaml 0% <ø> (ø) ⬆️
...nsion/GoogleCloudExtension.GCloud/GCloudWrapper.cs 0% <ø> (ø) ⬆️
.../TemplateChooserDialog/TemplateChooserViewModel.cs 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3398931...6ab17d2. Read the comment docs.

@ivannaranjo ivannaranjo requested a review from Deren-Liao October 9, 2017 13:07
@ivannaranjo
Copy link
Contributor Author

Ping?

Copy link

@ILMTitan ILMTitan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivannaranjo ivannaranjo merged commit 9ece9b9 into master Oct 10, 2017
@ivannaranjo ivannaranjo deleted the q3_master_release branch October 10, 2017 13:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants