This repository was archived by the owner on May 16, 2025. It is now read-only.
Make MVC the default for the new template dialog box. #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the Template Chooser Window Margins to match the Microsoft UX Style Guide.
Codecov Report
@@ Coverage Diff @@
## q3_master_release #822 +/- ##
==================================================
Coverage 11.97% 11.97%
==================================================
Files 505 505
Lines 12331 12331
==================================================
Hits 1477 1477
Misses 10854 10854
Continue to review full report at Codecov.
|
Contributor
|
Can you change the target of the PR to the release branch instead? The |
ivannaranjo
reviewed
Oct 4, 2017
| closeWindow(); | ||
| }, | ||
| false); | ||
| AppType != AppType.None); |
Contributor
There was a problem hiding this comment.
Can this ever be false though? With radio boxes one of the two (mutually exclusive) options will always be selected. The value of the property should never be AppType.None.
iantalarico
approved these changes
Oct 4, 2017
| Target="{Binding ElementName=_projectIdBox}" | ||
| Margin="0,0,0,5"/> | ||
| <StackPanel Orientation="Horizontal" Margin="0,0,0,8"> | ||
| <TextBox x:Name="_projectIdBox" Text="{Binding GcpProjectId}" Width="200" Margin="0,0,5,0"/> |
ivannaranjo
added a commit
that referenced
this pull request
Oct 10, 2017
* Make MVC the default for the new template dialog box. (#822) Make MVC the default for the new template dialog box. Change the Template Chooser Window Margins to match the Microsoft UX Style Guide. * Updating the gcloud dependency and version number. (#824) * Updating the extension version to 1.2.10.0 * Udpating the minimuim requirement to version 174 of the Cloud SDK.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #814.
Make MVC the default for the new template dialog box.
Change the margins of the Template Chooser dialog to match the Microsoft UX Style Guide.