Conversation
added 5 commits
April 30, 2024 16:29
…e optional params for state and progress. Needed to be able to update the thumbnails only.
…soon as it is available
…dated thumbnail for images
…on as it is ready
… if there's a pending or failed upload. It also updates the code to be able to update the media thumbnail when there's no state update passed as a param.
|
Size Change: 0 B Total Size: 1.75 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @dangermattic, @mzorz. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Tests - iOSGallery - 1
Gallery - 2
MediaText - 1
MediaText - 2
MultipleUpload - 1
Image - 1
Cover - 1
cover_block.mp4 |
Contributor
Tests - AndroidGallery - 1
Gallery - 2
MediaText - 1
MediaText - 2
MultipleUpload - 1
Image - 1
Cover - 1 |
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
May 27, 2024
…f the media block is removed (WordPress#61251) * React Native Bridge - Update mediaUploadUpdate and mediaUpdate to have optional params for state and progress. Needed to be able to update the thumbnails only. * Media & Text - Update updateMediaProgress to update the thumbnail as soon as it is available * Media & Text - Pass new callback onMediaThumbnailUpdate to set the updated thumbnail for images * Cover block - Update onUpdateMediaProgress to set the thumbnail as soon as it is ready * Media Upload Progress - Request cancelling an image upload on unmount if there's a pending or failed upload. It also updates the code to be able to update the media thumbnail when there's no state update passed as a param. * Adds requestImageUploadCancel mock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/WordPress-iOS#23124
Fixes wordpress-mobile/gutenberg-mobile#1595
Related PRs:
What?
Currently, when an image block (Image, Media&Text, Cover) is removed with an ongoing or failed upload, the media upload is not canceled.
Why?
The media upload is expected to be canceled if the block is removed and the upload hasn't finished or if it failed to upload for any reason.
How?
Since the
MediaUploadProgresscomponent handles the upload states, I added the logic to cancel the upload when the component is removed and there's an ongoing/failed upload.There was already a method
requestImageUploadCancelin the bridge for both iOS and Android that cancels an upload from a media ID.A new function was added to set the
mediaUrlused for the thumbnail without having to pass the progress state, to prevent messing with the progress bar while the upload is happening.Changes for
mediaUploadUpdateandmediaUpdatewere needed for the iOS bridge functions to setprogress,state, andserverIDas optional params. See the iOS change for this use case.Media&TextandCoverblocks were updated to show the thumbnail right away with these changes. The Image block was already updated to expect these updates.Testing Instructions
Note
Please use the following test builds to test these changes:
Removing an Image block with an ongoing/failed upload
Tip
For iOS I suggest using the Network Link Conditioner tool in the Developer settings
For Android there are apps like
Network Speed BoosterI'd suggest going through all of the media upload tests or at least some of them:
Gallery - 1
Gallery - 2
MediaText - 1
MediaText - 2
MultipleUpload - 1
Image - 1
Cover - 1
Testing Instructions for Keyboard
N/A
Screenshots or screencast
RemoveUpload.mov