Fixes WordPress 6.7 warning about loading translations too early#479
Closed
akirk wants to merge 1 commit intoWordPress:trunkfrom
Closed
Fixes WordPress 6.7 warning about loading translations too early#479akirk wants to merge 1 commit intoWordPress:trunkfrom
akirk wants to merge 1 commit intoWordPress:trunkfrom
Conversation
kasparsd
approved these changes
Oct 16, 2025
kasparsd
left a comment
There was a problem hiding this comment.
This looks good! What are the next steps to get this merged in?
|
@Clorith I noticed that you've been doing most of the recent releases. Please let me know if there is anything else needed here to get this merged and released. Getting an official community plugin comply with the recent core changes would be beneficial to users. |
Clorith
added a commit
that referenced
this pull request
Dec 30, 2025
…slation are loaded too early after the changes to WordPress 6.7. Builds on input and suggestions from various contributors and tickets/pull requests. Props @kasparsd, @akirk, @EvanHerman, @lightningspirit. Fixes #477. Closes #478, #479, #488, #492.
Member
|
Fixed in f0f2875 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short introduction
Description of what the PR accomplishes
Admittedly, I cannot see a change in behavior, translations are loaded in the user language even without this PR. Still, I believe it is best practice to load the translations through the hook.
This error message is thrown before the PR: