Connectors: Register Akismet as a default non-AI connector#11688
Closed
jorgefilipecosta wants to merge 4 commits intoWordPress:trunkfrom
Closed
Connectors: Register Akismet as a default non-AI connector#11688jorgefilipecosta wants to merge 4 commits intoWordPress:trunkfrom
jorgefilipecosta wants to merge 4 commits intoWordPress:trunkfrom
Conversation
Adds Akismet to the default connector registry as a `spam_filtering` type, with plugin metadata pointing to `akismet/akismet.php` and API key authentication wired to the existing `wordpress_api_key` option / `WPCOM_API_KEY` constant. The `is_active` callback defaults to `__return_false` so the connector reports inactive until the Akismet plugin overrides it from its own registration.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
The default connector registry now includes Akismet, which is a `spam_filtering` connector that uses the legacy `wordpress_api_key` option. Update the test expectations to allow non-AI connector types and skip the AI-specific `connectors_ai_{id}_api_key` setting-name format check for them.
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
gziolo
approved these changes
May 5, 2026
Member
gziolo
left a comment
There was a problem hiding this comment.
As noted inline, the code diverged from the description. Regardless, thr implementation looks correct to me as the connector will be considered as active only when the plugin code runs.
pento
pushed a commit
that referenced
this pull request
May 6, 2026
Akismet is bundled with WordPress core, but it wasn't appearing on the Connectors screen even when present on the file system. Partially reverts [62210], bringing back the main part of [62193]. Follow-up to [62210], [62193]. Developed in #11688. Props audrasjb, bluefuton, davidbaumwald, desrosj, eclev91, gziolo, johnbillion, jorbin, jorgefilipecosta, lukecarbis, matt, matveb, peterwilsoncc, westonruter. See #65012. git-svn-id: https://develop.svn.wordpress.org/trunk@62310 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
May 6, 2026
Akismet is bundled with WordPress core, but it wasn't appearing on the Connectors screen even when present on the file system. Partially reverts [62210], bringing back the main part of [62193]. Follow-up to [62210], [62193]. Developed in WordPress/wordpress-develop#11688. Props audrasjb, bluefuton, davidbaumwald, desrosj, eclev91, gziolo, johnbillion, jorbin, jorgefilipecosta, lukecarbis, matt, matveb, peterwilsoncc, westonruter. See #65012. Built from https://develop.svn.wordpress.org/trunk@62310 git-svn-id: http://core.svn.wordpress.org/trunk@61590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pento
pushed a commit
that referenced
this pull request
May 7, 2026
Akismet is bundled with WordPress core, but it wasn't appearing on the Connectors screen even when present on the file system. Partially reverts [62210], bringing back the main part of [62193]. Follow-up to [62210], [62193]. Developed in #11688. Reviewed by gziolo. Merges [62310] to the 7.0 branch. Props audrasjb, bluefuton, davidbaumwald, desrosj, eclev91, gziolo, johnbillion, jorbin, jorgefilipecosta, lukecarbis, matt, matveb, peterwilsoncc, westonruter. Fixes #65012. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62319 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
May 7, 2026
Akismet is bundled with WordPress core, but it wasn't appearing on the Connectors screen even when present on the file system. Partially reverts [62210], bringing back the main part of [62193]. Follow-up to [62210], [62193]. Developed in WordPress/wordpress-develop#11688. Reviewed by gziolo. Merges [62310] to the 7.0 branch. Props audrasjb, bluefuton, davidbaumwald, desrosj, eclev91, gziolo, johnbillion, jorbin, jorgefilipecosta, lukecarbis, matt, matveb, peterwilsoncc, westonruter. Fixes #65012. Built from https://develop.svn.wordpress.org/branches/7.0@62319 git-svn-id: http://core.svn.wordpress.org/branches/7.0@61599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spam_filteringtype.akismet/akismet.phpwith anis_activecallback.wordpress_api_keyoption /WPCOM_API_KEYconstant for API key authentication, and points users tohttps://akismet.com/get/for credentials.Must be tested with akismet installed, as the connector only appears if akismet is installed, does not needs activation.
Ticket: https://core.trac.wordpress.org/ticket/65012
Test plan
is_activeasfalse.is_activecallback, confirm the connector reportsis_activeastrue.wordpress_api_keyoption andWPCOM_API_KEYconstant are picked up as credentials.