[improve][client] [PIP-165] Auto release client useless connections#16165
Merged
Technoboy- merged 19 commits intoapache:masterfrom Jul 28, 2022
Merged
[improve][client] [PIP-165] Auto release client useless connections#16165Technoboy- merged 19 commits intoapache:masterfrom
Technoboy- merged 19 commits intoapache:masterfrom
Conversation
5bf9e4b to
ea7e987
Compare
Contributor
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
|
@Jason918 @codelipenghui @gaoran10 @Technoboy- @gaozhangmin @congbobo184 could you take a look |
gaozhangmin
requested changes
Jun 24, 2022
Contributor
gaozhangmin
left a comment
There was a problem hiding this comment.
Overall look good to me, Please correct the javadocs.
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ClientBuilder.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java
Outdated
Show resolved
Hide resolved
Contributor
Author
Thanks for helping to correct it. |
poorbarcode
commented
Jun 24, 2022
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java
Outdated
Show resolved
Hide resolved
poorbarcode
commented
Jun 24, 2022
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java
Outdated
Show resolved
Hide resolved
gaozhangmin
requested changes
Jun 28, 2022
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java
Outdated
Show resolved
Hide resolved
517f38b to
df4da85
Compare
Technoboy-
reviewed
Jul 27, 2022
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConnectionPool.java
Outdated
Show resolved
Hide resolved
Technoboy-
reviewed
Jul 27, 2022
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConnectionPool.java
Outdated
Show resolved
Hide resolved
AlphaWang
suggested changes
Jul 27, 2022
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@codelipenghui @Technoboy- @AlphaWang @congbobo184 @gaozhangmin I extract a new class |
mattisonchao
approved these changes
Jul 27, 2022
Member
mattisonchao
left a comment
There was a problem hiding this comment.
LGTM, I left some questions, I hope you can answer them.
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConnectionPool.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/TransactionMetaStoreHandler.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java
Outdated
Show resolved
Hide resolved
Member
|
@AlphaWang Please review again. |
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Technoboy-
reviewed
Jul 28, 2022
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/AutoCloseUselessClientConTXTest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@codelipenghui @Technoboy- @AlphaWang @congbobo184 @gaozhangmin I extract a new class |
Technoboy-
approved these changes
Jul 28, 2022
codelipenghui
approved these changes
Jul 28, 2022
Gleiphir2769
pushed a commit
to Gleiphir2769/pulsar
that referenced
this pull request
Aug 4, 2022
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15516
see: [PIP-165] Auto release client useless connections
Master Issue: #15516
Documentation
doc-requireddoc-not-neededdocdoc-complete