Skip to content

Implement wildcard version identifier "N.*"#636

Merged
fweikert merged 2 commits intobazelbuild:masterfrom
fweikert:lts_star
Nov 20, 2024
Merged

Implement wildcard version identifier "N.*"#636
fweikert merged 2 commits intobazelbuild:masterfrom
fweikert:lts_star

Conversation

@fweikert
Copy link
Member

Unlike the floating version identifier "N.x", "N.*" can also return release candidates.

Fixes #630

Unlike the floating version identifier "N.x", "N.*" can also return release candidates.

Fixes bazelbuild#630
@meteorcloudy
Copy link
Member

Ah, I like this new syntax.

@meteorcloudy
Copy link
Member

/cc @fmeum @alexeagle

Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexeagle
Copy link
Contributor

yeah that's perfect 💚

@fweikert fweikert merged commit 1f492e5 into bazelbuild:master Nov 20, 2024
@meteorcloudy
Copy link
Member

meteorcloudy commented Nov 21, 2024

Error message is slight wrong when using "8.x":

$ bazel version
2024/11/21 11:46:23 could not download Bazel: could not resolve the version '8.x' to an actual version number: unable to determine latest version: there are no LTS releases or candidates

"or candidates" should be removed.

fweikert added a commit to fweikert/bazelisk that referenced this pull request Nov 21, 2024
fweikert added a commit that referenced this pull request Nov 21, 2024
* Improve error message for missing LTS binaries

Follow-up to #636.

* Remove obsolete import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

N.x version pattern should match release candidates

3 participants