fix: mark files that are attched as read #1777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this also makes sure that we do not reattach a file that did not chage and we already read
628944e to
de46bbd
Compare
caarlos0
approved these changes
Jan 6, 2026
Clauscomputing
pushed a commit
to Clauscomputing/crush
that referenced
this pull request
Jan 7, 2026
BrunoKrugel
pushed a commit
to BrunoKrugel/crush
that referenced
this pull request
Jan 7, 2026
LarsArtmann
reviewed
Jan 7, 2026
Comment on lines
+4
to
+7
| // TODO: Consider moving this to persistent storage (e.g., the database) to | ||
| // preserve file access history across sessions. | ||
| // We would need to make sure to handle the case where we reload a session and the underlying files did change. | ||
| package filetracker |
There was a problem hiding this comment.
Should this be a GitHub Issue on it's own?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the file attach behavior so that we record when a file is read and also do not attach files that have been already read and did not change