perf: fix possibly unclosed resp.body #1818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a resource leak in the TestConnection function where the HTTP response body would not be closed if the function returned early due to status code validation failures.
Key changes:
- Moved response body closing to use
deferimmediately after the HTTP request succeeds - Renamed variable from
btorespfor clarity - Fixed comment capitalization
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kujtimiihoxha
approved these changes
Jan 12, 2026
BrunoKrugel
pushed a commit
to BrunoKrugel/crush
that referenced
this pull request
Jan 12, 2026
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
puffitos
pushed a commit
to puffitos/crush
that referenced
this pull request
Jan 13, 2026
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
puffitos
pushed a commit
to puffitos/crush
that referenced
this pull request
Jan 13, 2026
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if it fell into one of the ifs there, it would not close the response body.