fix: harden proxy-table matching to prevent routing bypass#1268
Merged
Conversation
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Author
|
Annoying that CI is being flakey - in my fork CI passed with only one rerun being needed :/ |
Owner
|
This is one of the reasons not to support v2 anymore 🫥 CI stability has been improved in v4 and doesn't rely on third-party for e2e tests... |
|
coverage: 98.113% (+0.04%) from 98.072% — G-Rath:backport into chimurai:2.x |
Owner
|
https://github.com/chimurai/http-proxy-middleware/releases/tag/v2.0.10 published to https://www.npmjs.com/package/http-proxy-middleware/v/2.0.10 Thanks for the backport! |
Closed
2 tasks
mbouaziz
added a commit
to SkipLabs/skip
that referenced
this pull request
Jul 10, 2026
## Summary Addresses Dependabot alert [342](https://github.com/SkipLabs/skip/security/dependabot/342) — [GHSA-64mm-vxmg-q3vj](GHSA-64mm-vxmg-q3vj) / CVE-2026-55602 (**medium**: `http-proxy-middleware` `router` host+path substring matching allows a Host-header-driven backend routing bypass). The advisory has three per-major ranges; the one that applies here is `>= 0.16.0, < 2.0.10` → patched **2.0.10**. `www` had `http-proxy-middleware@2.0.9`. ## Fix Transitive dep of `webpack-dev-server` (`^2.0.9`), so a plain `npm update http-proxy-middleware --package-lock-only` bumps it to **2.0.10** within range — no override needed. Single-package, 3-line diff. ## Breaking-change check 2.0.10's only code change is [`fix: harden proxy-table matching to prevent routing bypass` (#1268)](chimurai/http-proxy-middleware#1268) — the security fix itself — plus a CI publish chore. The public API is unchanged; semver-patch. ## Verification - Fresh `npm install` → single `http-proxy-middleware@2.0.10`; no copy in any advisory range (`0.16.0–2.0.10`, `3.0.0–3.0.6`, `4.0.0–4.1.0`). - Diff scoped to the one package. Dev-only tooling — `webpack-dev-server`'s proxy during `docusaurus start`; never runs in CI or reaches the shipped static site. _(Referencing the Dependabot alert by URL rather than `#342` to avoid GitHub's auto-close keyword colliding with an unrelated PR/issue number.)_ 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backports security fix for GHSA-64mm-vxmg-q3vj
fixes #1266
Motivation and Context
v2 is heavily used by dependencies such as
webpack-dev-serverso having a backport would be very helpful for the ecosystemHow has this been tested?
Using the reproduction and with the ported tests
Types of changes
Checklist:
My change requires a change to the documentation.I have updated the documentation accordingly.Summary by CodeRabbit