fix(target-size): ignore widgets that are inline with other inline elements by straker · Pull Request #5000 · dequelabs/axe-core

straker · 2026-01-29T22:23:26Z

Closes: #4392

…ments

WilcoFiers

I think you went off track with this fix. The real issue I think is much simpler, that we just need to be allow inline-block elements to be considered inline for the purpose of target-size (as that's the permissive approach for it) and for them to be blocks for link-in-text-block (as that's the permissive approach there).

#5009

While reviewing #5000 I found the approach wasn't working as I was expecting. Playing around with examples I found a simpler way to do this. IDK if this is everything we should do, but I think this gets us close. I decided to put this in its own PR since this was too much code to put into comments.

…-core into target-size-inline

Resolved

chutchins25

Review

1. Test describe block uses stale option name (Important)

test/commons/dom/is-in-text-block.js:335

The describe block is labeled 'with options.permissive: true' but the option was renamed to includeInlineBlock (by #5009). Should be updated to match the actual API.

2. Test description contradicts assertion (Important)

test/commons/dom/is-in-text-block.js:387

The test 'returns true if inline-block element has a sibling on the same line' asserts isFalse. The test passes because "world" is shorter than "button 2" so the length comparison fails — but the description claims the opposite result. Please update the description to match the actual expected behavior.

3. PR title typo (Suggestion)

Minor: "wigets" → "widgets" in the PR title.

Resolved

WilcoFiers

LGTM. I contributed too much to this. I don't think I can approve this.

chutchins25

Looks good to me!

…ements (#5000) Closes: #4392 --------- Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> Co-authored-by: Wilco Fiers <wilco.fiers@deque.com>

### [4.11.2](v4.11.1...v4.11.2) (2026-03-30) ### Bug Fixes - **aria-valid-attr-value:** handle multiple aria-errormessage IDs ([#4973](#4973)) ([9322148](9322148)) - **aria:** prevent getOwnedVirtual from returning duplicate nodes ([#4987](#4987)) ([99d1e77](99d1e77)), closes [#4840](#4840) - **DqElement:** avoid calling constructors with cloneNode ([#5013](#5013)) ([88bc57f](88bc57f)) - **existing-rule:** aria-busy now shows an error message for a use with unallowed children ([#5017](#5017)) ([dded75a](dded75a)) - **scrollable-region-focusable:** clarify the issue is in safari ([#4995](#4995)) ([2567afd](2567afd)), closes [WebKit#190870](https://github.com/dequelabs/WebKit/issues/190870) [WebKit#277290](https://github.com/dequelabs/WebKit/issues/277290) - **scrollable-region-focusable:** do not fail scroll areas when all content is visible without scrolling ([#4993](#4993)) ([240f8b5](240f8b5)) - **target-size:** determine offset using clientRects if target is display:inline ([#5012](#5012)) ([69d81c1](69d81c1)) - **target-size:** ignore widgets that are inline with other inline elements ([#5000](#5000)) ([cf8a3c0](cf8a3c0))

## [4.12.0](v4.11.4...v4.12.0) (2026-06-01) ### Features - add gather-internals.js external script ([#5099](#5099)) ([c61d58b](c61d58b)), closes [#5080](#5080) - **aria-allowed/prohibited-attr, aria-required-parent/children:** partially support element internals role ([#5080](#5080)) ([417b48a](417b48a)), closes [#5039](#5039) [#4259](#4259) - **axe.externalAPIs:** add public api for setting elementInternal data ([#5105](#5105)) ([63bab8f](63bab8f)) - **core:** expose normalizeRunOptions ([#4998](#4998)) ([b8e6a59](b8e6a59)) - expose axe.resetLocale() to restore the default locale ([#5108](#5108)) ([c2b5292](c2b5292)), closes [#5107](#5107) - **getRules:** include rule enabled state in returned objects ([#5118](#5118)) ([75bf772](75bf772)), closes [#5116](#5116) - **list,listitem:** support element internals role ([#5119](#5119)) ([7d9d696](7d9d696)) - **new-rule:** check that aria-tab have an accessible name ([#5001](#5001)) ([0d4e4e7](0d4e4e7)), closes [#4842](#4842) - **rules:** deprecate landmark-complementary-is-top-level rules ([#4992](#4992)) ([9e09139](9e09139)), closes [#4950](#4950) - **utils:** add `getElementInternals` function ([#5077](#5077)) ([1c15f82](1c15f82)) ### Bug Fixes - **aria-allowed-attr:** restrict br and wbr elements to aria-hidden only ([#4974](#4974)) ([c6245e7](c6245e7)) - **aria-conditional-attr:** add support for radio ([#5100](#5100)) ([8223c98](8223c98)) - **aria-valid-attr-value:** handle multiple aria-errormessage IDs ([#4973](#4973)) ([0489e30](0489e30)) - **aria:** prevent getOwnedVirtual from returning duplicate nodes ([#4987](#4987)) ([48ca955](48ca955)), closes [#4840](#4840) - **commons/text:** exclude natively hidden elements from aria-labelledby accessible name ([#5076](#5076)) ([ea7202c](ea7202c)), closes [#4704](#4704) - **DqElement:** avoid calling constructors with cloneNode ([#5013](#5013)) ([0281fa1](0281fa1)) - **existing-rule:** aria-busy now shows an error message for a use with unallowed children ([#5017](#5017)) ([2067b87](2067b87)) - **helpUrl:** ensure axe.configure always updates the help URLs ([#5114](#5114)) ([c4f60ff](c4f60ff)) - **label-content-name-mismatch:** match visible text with aria-label and exclude invisible text ([#5096](#5096)) ([3a012a1](3a012a1)) - **locale:** ensure all subtags are correctly set ([#5112](#5112)) ([13005ed](13005ed)) - **scrollable-region-focusable:** clarify the issue is in safari ([#4995](#4995)) ([4ec5211](4ec5211)), closes [WebKit#190870](https://github.com/dequelabs/WebKit/issues/190870) [WebKit#277290](https://github.com/dequelabs/WebKit/issues/277290) - **scrollable-region-focusable:** do not fail scroll areas when all content is visible without scrolling ([#4993](#4993)) ([838707a](838707a)) - **target-size:** determine offset using clientRects if target is display:inline ([#5012](#5012)) ([a4b8091](a4b8091)) - **target-size:** ignore position: fixed elements that are offscreen when page is scrolled ([#5066](#5066)) ([1229a6e](1229a6e)), closes [#5065](#5065) - **target-size:** ignore widgets that are inline with other inline elements ([#5000](#5000)) ([a8dd81b](a8dd81b)) - **utils/getAncestry:** escape node name ([#5079](#5079)) ([d1fabaa](d1fabaa)), closes [#5078](#5078) - **utils:** Add null check to parseCrossOriginStylesheet, closes [#5074](#5074) ([#5075](#5075)) ([f12ef32](f12ef32)) - **utils:** update isShadowRoot to use spec-compliant custom element regex ([#5059](#5059)) ([edc6ce2](edc6ce2)), closes [#5030](#5030) This PR was opened by a robot 🤖 🎉

straker added 2 commits January 29, 2026 15:21

fix(target-size): ignore wigets that are inline with other inline ele…

54a8882

…ments

revert changes that somehow got reverted

00070a6

straker requested a review from a team as a code owner January 29, 2026 22:23

straker marked this pull request as draft January 29, 2026 23:52

straker added 2 commits February 2, 2026 16:17

tests

118d104

test

256d1c1

straker marked this pull request as ready for review February 2, 2026 23:19

WilcoFiers added a commit that referenced this pull request Feb 4, 2026

chore(text-block): suggest changes to PR #5000

4031678

WilcoFiers mentioned this pull request Feb 4, 2026

chore(text-block): suggest changes to PR #5000 #5009

Merged

WilcoFiers previously requested changes Feb 4, 2026

View reviewed changes

WilcoFiers and others added 4 commits February 5, 2026 13:55

Suggested tweaks

931a8ff

Merge branch 'develop' into target-size-inline

b12e740

Merge branch 'target-size-inline' of https://github.com/dequelabs/axe…

44fc664

…-core into target-size-inline

fix id number

6e35ae1

straker force-pushed the target-size-inline branch from b204032 to 6e35ae1 Compare March 24, 2026 19:47

chutchins25 previously requested changes Mar 25, 2026

View reviewed changes

suggestions

ee044e2

straker changed the title ~~fix(target-size): ignore wigets that are inline with other inline elements~~ fix(target-size): ignore widgets that are inline with other inline elements Mar 25, 2026

WilcoFiers reviewed Mar 25, 2026

View reviewed changes

chutchins25 approved these changes Mar 26, 2026

View reviewed changes

Merge branch 'develop' into target-size-inline

595fafb

WilcoFiers merged commit a8dd81b into develop Mar 26, 2026
23 checks passed

WilcoFiers deleted the target-size-inline branch March 26, 2026 16:06

attest-team-ci mentioned this pull request Mar 30, 2026

chore(release): v4.12.0 #5047

Closed

WilcoFiers mentioned this pull request Mar 30, 2026

chore(release): patch cherry-picks from develop #5048

Closed

straker mentioned this pull request Mar 30, 2026

chore(release): v4.11.2 #5049

Merged

attest-team-ci mentioned this pull request Jun 1, 2026

chore(release): v4.12.0 #5122

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(target-size): ignore widgets that are inline with other inline elements#5000

fix(target-size): ignore widgets that are inline with other inline elements#5000
WilcoFiers merged 11 commits into
developfrom
target-size-inline

straker commented Jan 29, 2026

Uh oh!

WilcoFiers left a comment

Uh oh!

chutchins25 left a comment

Uh oh!

WilcoFiers left a comment

Uh oh!

chutchins25 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

straker commented Jan 29, 2026

Uh oh!

WilcoFiers left a comment

Choose a reason for hiding this comment

Uh oh!

chutchins25 left a comment

Choose a reason for hiding this comment

Review

1. Test describe block uses stale option name (Important)

2. Test description contradicts assertion (Important)

3. PR title typo (Suggestion)

Uh oh!

WilcoFiers left a comment

Choose a reason for hiding this comment

Uh oh!

chutchins25 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants