feat: added UPPER_CASE_WITH_UNDERSCORES in FieldNamingPolicy#2024
feat: added UPPER_CASE_WITH_UNDERSCORES in FieldNamingPolicy#2024eamonnmcmanus merged 7 commits intomasterfrom unknown repository
Conversation
eamonnmcmanus
left a comment
There was a problem hiding this comment.
Thanks!
Gson is in maintenance mode and we are reluctant to accept new features. However, this is really just a variant of existing features, so I think we can make an exception and take it.
Marcono1234
left a comment
There was a problem hiding this comment.
It might require some minor documentation adjustments.
But besides that it is great how well you integrated it into the existing tests!
Note that I am not a member of Gson, so please consider my review comments only as suggestions.
…ITH_UNDERSCORES_Field_Name_Policy
Thank you so much for reviewing it! Somehow I messed up the committed request from you so I had to make the change and re-commit, hopefully that's okay. The issues are fixed though. |
|
@eamonnmcmanus could you please close #1886 now that this has been integrated? And @yixingz3 as hint for the future: GitHub understands certain keywords which can be used to automatically link pull requests and issues. When a pull request is then merged, GitHub will automatically close the linked issue(s). |
|
@Marcono1234 Thank you for the tips! Next time I'll make sure to use one of the keywords :) |
## [0.3.0](0.2.4...0.3.0) (2022-01-08) ### Features * added UPPER_CASE_WITH_UNDERSCORES in FieldNamingPolicy ([google#2024](https://github.com/DanySK/gson-extras/issues/2024)) ([eaf9a03](eaf9a03)) * merge branch 'master' of https://github.com/google/gson into google-master ([78a4285](78a4285)) * merge branch master of https://github.com/google/gson [#100](#100) ([d399bd9](d399bd9))
For issue #1886