BoundField.write memory optimization#2325
Merged
eamonnmcmanus merged 2 commits intogoogle:masterfrom Feb 28, 2023
Merged
Conversation
Declare and initialize the type adapter used for writing BoundFields outside of the anonymous class to ensure that a new TypeAdapterRuntimeTypeWrapper is not constructed each time a BoundField is written. This type adapter is only initialized if the BoundField will be used for serialization.
Contributor
Member
I took the liberty of updating the PR description. |
eamonnmcmanus
requested changes
Feb 26, 2023
| : new TypeAdapterRuntimeTypeWrapper<>(context, typeAdapter, fieldType.getType()); | ||
| } else { | ||
| // The field will never be serialized, skip the unnecessary type adapter construction | ||
| writeTypeAdapter = null; |
Member
There was a problem hiding this comment.
While this is correct, I think it's likely to confuse nullness-analysis tools. It's just as easy to set this to typeAdapter here, which should confuse them less.
Contributor
Author
There was a problem hiding this comment.
Fair point, updated now.
eamonnmcmanus
approved these changes
Feb 28, 2023
Member
eamonnmcmanus
left a comment
There was a problem hiding this comment.
Looks great. Thanks again for doing this!
tibor-universe
pushed a commit
to getuniverse/gson
that referenced
this pull request
Sep 14, 2024
* BoundField.write memory optimization Declare and initialize the type adapter used for writing BoundFields outside of the anonymous class to ensure that a new TypeAdapterRuntimeTypeWrapper is not constructed each time a BoundField is written. This type adapter is only initialized if the BoundField will be used for serialization. * Avoid confusing nullness-analysis tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declare and initialize the type adapter used for writing BoundFields outside of the anonymous class to ensure that a new TypeAdapterRuntimeTypeWrapper is not constructed each time a BoundField is written. This type adapter is only initialized if the BoundField will be used for serialization.
See #2321 for more details.
Closes #2321.