feat: support GOOGLE_CLOUD_PROJECT_ID fallback (fixes #2262) by Gosling-dude · Pull Request #2725 · google-gemini/gemini-cli

Gosling-dude · 2025-06-30T17:42:36Z

This pull request enhances environment variable handling by introducing support for the GOOGLE_CLOUD_PROJECT_ID environment variable as a fallback to the existing GOOGLE_CLOUD_PROJECT variable.

What this fixes

Previously, the Gemini CLI only accepted GOOGLE_CLOUD_PROJECT for Google Cloud project identification. However, some users (especially those following other GCP tools or documentation) use GOOGLE_CLOUD_PROJECT_ID instead. This mismatch caused confusion and authentication issues, as highlighted in issue #2262.

What this PR does

Updates all relevant code paths to check both GOOGLE_CLOUD_PROJECT and GOOGLE_CLOUD_PROJECT_ID, defaulting to the first available.
Ensures backward compatibility with existing users while supporting an alternative common variable name.
Improves robustness and reduces potential user misconfiguration when authenticating with Google Cloud.

Affected files

slashCommandProcessor.ts
setup.ts
contentGenerator.ts

Impact

This small but important enhancement increases flexibility and improves developer experience without introducing breaking changes.

Fixes: #2262

gemini-code-assist

Summary of Changes

Hello @Gosling-dude, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the application's flexibility by adding support for an alternative environment variable (GOOGLE_CLOUD_PROJECT_ID) for specifying the Google Cloud project. This change addresses user confusion and potential authentication issues, providing a more robust and user-friendly experience without introducing breaking changes.

Highlights

Environment Variable Fallback: Introduces support for GOOGLE_CLOUD_PROJECT_ID as a fallback to GOOGLE_CLOUD_PROJECT for Google Cloud project identification.
Backward Compatibility: Ensures existing users relying on GOOGLE_CLOUD_PROJECT are not affected by the change.
Improved Robustness: Reduces potential user misconfiguration when authenticating with Google Cloud.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

The pull request effectively implements the fallback mechanism for GOOGLE_CLOUD_PROJECT_ID when GOOGLE_CLOUD_PROJECT is not set, aligning well with the stated objective of improving user experience and compatibility. The changes are minimal, well-contained, and consistently applied across the affected files. No critical or high-severity issues were identified during the review.

swissspidy · 2025-06-30T17:53:39Z

packages/cli/src/ui/hooks/slashCommandProcessor.ts

+//const gcpProject = process.env.GOOGLE_CLOUD_PROJECT || '';
+


This leftover code should be removed :)

Oops! Removed it now — thanks for the heads-up! 👍

Happy to help! Just looks like you haven't pushed the change yet

Just pushed the change now — thanks again for catching that! 🙌

swissspidy

We should also update the documentation, but otherwise LGTM

Gosling-dude · 2025-07-15T05:43:16Z

We should also update the documentation, but otherwise LGTM

Hi @swissspidy,
I’ve added the documentation for the GOOGLE_CLOUD_PROJECT_ID fallback. All checks are passing now—please let me know if there’s anything else before merging. Thanks!

Gosling-dude · 2025-08-11T05:13:12Z

@swissspidy @google-gemini/gemini-cli-askmode-approvers : could someone approve the workflow and give final review for PR #2725? Thanks!

mattKorwel · 2025-08-22T18:46:26Z

@Gosling-dude Trying to get this merged and I'm seeing what feels like an unrelated test failure. Can you try and pull and test on windows?

Thanks

Gosling-dude · 2025-08-24T10:51:56Z

@mattKorwel Preparing to push a clean branch with a single focused commit (env-var + docs) to fix the CLA commit-limit and simplify review. Before I push: do you allow a force-push to fix-env-var-2262? If not, I’ll push as a new branch/PR. After I push, could someone re-run CI / enable auto-merge? If the Windows job still fails, please share the failing test name/log and I’ll reproduce on Windows and fix. Thanks!

gsquared94 · 2025-09-09T07:52:13Z

@mattKorwel Preparing to push a clean branch with a single focused commit (env-var + docs) to fix the CLA commit-limit and simplify review. Before I push: do you allow a force-push to fix-env-var-2262? If not, I’ll push as a new branch/PR. After I push, could someone re-run CI / enable auto-merge? If the Windows job still fails, please share the failing test name/log and I’ll reproduce on Windows and fix. Thanks!

you should be able to force push since the branch in on your fork. It will however reset the approval.

Gosling-dude · 2025-10-06T18:47:29Z

Hi @mattKorwel and @swissspidy,

I've pushed the cleaned-up branch as discussed. The pull request now has a single, focused commit and should be ready for a final review.

Could you please approve the workflows to run the CI checks?

Thanks!

Gosling-dude · 2025-10-08T17:18:00Z

@mattKorwel @swissspidy This update resolves all the previous issues. I've squashed the commits, fixed the linting errors, and rebased onto the latest main. This is now clean and ready for a final review and workflow approval.

@Gosling-dude Trying to get this merged and I'm seeing what feels like an unrelated test failure. Can you try and pull and test on windows?

Thanks

swissspidy · 2025-10-08T17:30:34Z

Looks like you'll need to run Prettier again.

Gosling-dude · 2025-10-08T17:43:34Z

Looks like you'll need to run Prettier again.

@swissspidy I've just pushed the fix for the formatting. All CI checks should be passing now. Ready for that final review!

Gosling-dude · 2025-10-08T18:55:45Z

Hi @swissspidy and @mattKorwel,

I was able to get the detailed logs for the merge queue failure.

The failing job is E2E Test (macOS), and the specific test failing is file-system-interactive.test.ts with an assertion error (expected '1.0.0' to be '1.0.1').

This seems to confirm it's an unrelated test issue. Please let me know if there's anything else I can do to help!

)

fixes google-gemini#2262) (google-gemini#2725)

) (google-gemini#2725)

Gosling-dude requested a review from a team as a code owner June 30, 2025 17:42

gemini-code-assist bot reviewed Jun 30, 2025

View reviewed changes

swissspidy reviewed Jun 30, 2025

View reviewed changes

gemini-cli bot added good first issue priority/p2 Important but can be addressed in a future release. labels Jul 3, 2025

Gosling-dude requested a review from swissspidy July 14, 2025 04:53

swissspidy previously approved these changes Jul 14, 2025

View reviewed changes

Gosling-dude dismissed swissspidy’s stale review via 6920462 July 15, 2025 05:31

mattKorwel approved these changes Aug 22, 2025

View reviewed changes

mattKorwel enabled auto-merge August 22, 2025 18:34

mattKorwel self-assigned this Aug 22, 2025

auto-merge was automatically disabled August 23, 2025 02:25
Head branch was pushed to by a user without write access

Gosling-dude force-pushed the fix-env-var-2262 branch from 3b3e455 to 58e72d6 Compare August 23, 2025 02:25

gemini-cli bot added the status/need-issue label Sep 16, 2025

Gosling-dude force-pushed the fix-env-var-2262 branch from 58e72d6 to d8a0a19 Compare October 6, 2025 18:42

Gosling-dude requested a review from a team as a code owner October 6, 2025 18:42

Gosling-dude force-pushed the fix-env-var-2262 branch 2 times, most recently from abcfaea to ad88f43 Compare October 8, 2025 17:10

Gosling-dude force-pushed the fix-env-var-2262 branch 2 times, most recently from 69edd8e to ac814b4 Compare October 8, 2025 17:42

swissspidy added this pull request to the merge queue Oct 8, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 8, 2025

feat: support GOOGLE_CLOUD_PROJECT_ID fallback (fixes google-gemini#2262

3c207da

)

Gosling-dude force-pushed the fix-env-var-2262 branch from ac814b4 to 3c207da Compare October 9, 2025 09:38

swissspidy added this pull request to the merge queue Oct 9, 2025

Merged via the queue into google-gemini:main with commit 0cd490a Oct 9, 2025
19 checks passed

thacio added a commit to thacio/auditaria that referenced this pull request Oct 9, 2025

Merge Commit '0cd490a': feat: support GOOGLE_CLOUD_PROJECT_ID fallback (

dd76623

fixes google-gemini#2262) (google-gemini#2725)

giraffe-tree pushed a commit to giraffe-tree/gemini-cli that referenced this pull request Oct 10, 2025

feat: support GOOGLE_CLOUD_PROJECT_ID fallback (fixes google-gemini#2262

3ea6a13

) (google-gemini#2725)

		//const gcpProject = process.env.GOOGLE_CLOUD_PROJECT \|\| '';

Conversation

Gosling-dude commented Jun 30, 2025

What this fixes

What this PR does

Affected files

Impact

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

swissspidy Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

Gosling-dude Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

swissspidy Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

Gosling-dude Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

swissspidy left a comment

Choose a reason for hiding this comment

Uh oh!

Gosling-dude commented Jul 15, 2025

Uh oh!

Gosling-dude commented Aug 11, 2025

Uh oh!

mattKorwel commented Aug 22, 2025

Uh oh!

Gosling-dude commented Aug 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gsquared94 commented Sep 9, 2025

Uh oh!

Gosling-dude commented Oct 6, 2025

Uh oh!

Gosling-dude commented Oct 8, 2025

Uh oh!

swissspidy commented Oct 8, 2025

Uh oh!

Gosling-dude commented Oct 8, 2025

Uh oh!

Uh oh!

Gosling-dude commented Oct 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Gosling-dude commented Aug 24, 2025 •

edited

Loading