Skip to content

Conversation

@dheerajpanangat
Copy link
Contributor

As part of BigQueryOptions or StorageOptions the SCOPES is defined as an ImmutableSet.
When using an Impersonated Account, it fails when trying to get service, as the SCOPES are immutableSet and the previous code tries to cast it to List directly and fails.
Adding a fix for the same.

Fixes #731 ☕️

As part of BigQueryOptions the SCOPES is defined as an ImmutableSet.
When using an Impersonated Account, it fails when trying to get service as the SCOPES are immutableSet and the previous code tries to cast it to List directly and fails.
Adding a fix for the same
@dheerajpanangat dheerajpanangat requested a review from a team as a code owner September 8, 2021 10:58
@google-cla
Copy link

google-cla bot commented Sep 8, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 8, 2021
@dheerajpanangat
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 28, 2021
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this. Can you add a simple test for this failure so that we don't regress in the future?

@dheerajpanangat
Copy link
Contributor Author

dheerajpanangat commented Oct 19, 2021

Thanks for submitting this. Can you add a simple test for this failure so that we don't regress in the future?

@chingor13 Added the JUnit Test case.
Thanks

@TimurSadykov TimurSadykov self-requested a review November 22, 2021 08:45
Copy link

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry for delay, some minor comments and we can get it done. Thanks!

@TimurSadykov TimurSadykov requested review from a team and Neenu1995 and removed request for a team February 3, 2022 18:24
Copy link

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimurSadykov
Copy link

@dpanangat hey, thanks for updates, please fix the linter failure and we should be good to go. To do that you need to run the "mvn com.coveo:fmt-maven-plugin:format" command and push resulted format changes.

@TimurSadykov TimurSadykov added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Mar 15, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 15, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 7dcd549 into googleapis:main Mar 15, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 15, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 16, 2022
🤖 I have created a release *beep* *boop*
---


## [1.6.0](v1.5.3...v1.6.0) (2022-03-15)


### Features

* Add AWS Session Token to Metadata Requests ([#850](#850)) ([577e9a5](577e9a5))


### Bug Fixes

* ImmutableSet converted to List for Impersonated Credentials ([#732](#732)) ([7dcd549](7dcd549))
* update library docs ([#868](#868)) ([a081015](a081015))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BigQuery/Storage - ImpersonatedCredentials fails when trying to get Service

5 participants