-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(bigtable): expose otel metrics to Bigtable #12827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Please fix vet failures |
Contributor
|
Please add pull request description |
sushanb
commented
Sep 9, 2025
bhshkh
reviewed
Sep 16, 2025
Contributor
bhshkh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the pull request description.
LGTM overall.
A few nits to improve conciseness and maintainability
bhshkh
approved these changes
Sep 16, 2025
bhshkh
pushed a commit
that referenced
this pull request
Sep 22, 2025
🤖 I have created a release *beep* *boop* --- ## [1.40.0](bigtable/v1.39.0...bigtable/v1.40.0) (2025-09-22) ### Features * **bigtable:** Expose otel native grpc metrics in Bigtable ([#12827](#12827)) ([e9d2efd](e9d2efd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scrapes the selected Otel metrics and exports the metrics to Cloud Bigtable Client schema.
This change instruments the Bigtable Go client to export a standard set of gRPC metrics to Google Cloud Monitoring using OpenTelemetry. The following metrics are now exported under the bigtable.googleapis.com/internal/client/ prefix:
These metrics are exported to a new Cloud Monitoring monitored resource type: bigtable_client.
This implementation follows the existing pattern within the metrics infrastructure where failures during metrics initialization do not prevent the successful creation of the Bigtable client, prioritizing application availability over metrics collection.
Unit tests have been added to validate the new functionality.