Skip to content

Conversation

@sushanb
Copy link
Contributor

@sushanb sushanb commented Sep 8, 2025

Scrapes the selected Otel metrics and exports the metrics to Cloud Bigtable Client schema.

This change instruments the Bigtable Go client to export a standard set of gRPC metrics to Google Cloud Monitoring using OpenTelemetry. The following metrics are now exported under the bigtable.googleapis.com/internal/client/ prefix:

  • grpc.client.attempt.duration
  • grpc.lb.rls.default_target_picks
  • grpc.lb.rls.target_picks
  • grpc.lb.rls.failed_picks
  • grpc.xds_client.server_failure
  • grpc.xds_client.resource_updates_invalid

These metrics are exported to a new Cloud Monitoring monitored resource type: bigtable_client.

This implementation follows the existing pattern within the metrics infrastructure where failures during metrics initialization do not prevent the successful creation of the Bigtable client, prioritizing application availability over metrics collection.

Unit tests have been added to validate the new functionality.

@sushanb sushanb requested review from a team as code owners September 8, 2025 21:13
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Sep 8, 2025
@bhshkh
Copy link
Contributor

bhshkh commented Sep 9, 2025

Please fix vet failures

@bhshkh
Copy link
Contributor

bhshkh commented Sep 9, 2025

Please add pull request description

@sushanb sushanb added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2025
Copy link
Contributor

@bhshkh bhshkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the pull request description.

LGTM overall.

A few nits to improve conciseness and maintainability

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 16, 2025
@bhshkh bhshkh enabled auto-merge (squash) September 16, 2025 21:33
@bhshkh bhshkh disabled auto-merge September 16, 2025 21:33
@sushanb sushanb merged commit e9d2efd into googleapis:main Sep 16, 2025
13 checks passed
bhshkh pushed a commit that referenced this pull request Sep 22, 2025
🤖 I have created a release *beep* *boop*
---


##
[1.40.0](bigtable/v1.39.0...bigtable/v1.40.0)
(2025-09-22)


### Features

* **bigtable:** Expose otel native grpc metrics in Bigtable
([#12827](#12827))
([e9d2efd](e9d2efd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants