Skip to content

Storage: Cleanup unused dependencies#5680

Merged
chingor13 merged 3 commits intogoogleapis:masterfrom
athakor:cleanup-dependency-storage-4383
Jul 30, 2019
Merged

Storage: Cleanup unused dependencies#5680
chingor13 merged 3 commits intogoogleapis:masterfrom
athakor:cleanup-dependency-storage-4383

Conversation

@athakor
Copy link
Contributor

@athakor athakor commented Jul 4, 2019

towards #4383

@athakor athakor requested a review from a team July 4, 2019 12:00
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 4, 2019
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2019
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 8, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 8, 2019
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2019
@chingor13 chingor13 changed the title Storage : Cleanup dependency Storage: Cleanup unused dependencies Jul 30, 2019
@chingor13 chingor13 self-assigned this Jul 30, 2019
@codecov
Copy link

codecov bot commented Jul 30, 2019

Codecov Report

Merging #5680 into master will increase coverage by 0.48%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5680      +/-   ##
============================================
+ Coverage     46.71%   47.19%   +0.48%     
- Complexity    24629    30191    +5562     
============================================
  Files          2351     2456     +105     
  Lines        256127   304938   +48811     
  Branches      29325    34736    +5411     
============================================
+ Hits         119648   143918   +24270     
- Misses       127559   151096   +23537     
- Partials       8920     9924    +1004
Impacted Files Coverage Δ Complexity Δ
.../main/java/com/google/cloud/bigquery/BigQuery.java 73.3% <0%> (-5.14%) 0% <0%> (ø)
...va/com/google/cloud/storage/spi/v1/StorageRpc.java 57.95% <0%> (-4.91%) 0% <0%> (ø)
...google/cloud/compute/v1/InsertDiskHttpRequest.java 19.77% <0%> (-4.66%) 13% <0%> (+3%)
.../cloud/compute/v1/InsertRegionDiskHttpRequest.java 19.77% <0%> (-4.66%) 13% <0%> (+3%)
...pute/v1/InsertInstanceGroupManagerHttpRequest.java 19.83% <0%> (-3.95%) 11% <0%> (+2%)
...pute/v1/InsertGlobalForwardingRuleHttpRequest.java 20% <0%> (-3.93%) 11% <0%> (+2%)
...ud/compute/v1/InsertForwardingRuleHttpRequest.java 20% <0%> (-3.93%) 11% <0%> (+2%)
...1/InsertRegionInstanceGroupManagerHttpRequest.java 19.91% <0%> (-3.87%) 11% <0%> (+2%)
...oud/compute/v1/InsertInstanceGroupHttpRequest.java 20.08% <0%> (-3.85%) 12% <0%> (+3%)
...oud/compute/v1/InsertBackendBucketHttpRequest.java 20.08% <0%> (-3.85%) 12% <0%> (+3%)
... and 630 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13928f8...df587ab. Read the comment docs.

@chingor13 chingor13 merged commit d23793b into googleapis:master Jul 30, 2019
@kolea2 kolea2 mentioned this pull request Jul 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

@chingor13 chingor13

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@athakor @chingor13 @googlebot @pmakani @yoshi-kokoro