Rebase by jean-philippe-martin · Pull Request #734 · googleapis/google-cloud-java

jean-philippe-martin · 2016-03-09T18:55:14Z

rebase to master in order to incorporate the fix for issue #720

- Dataset extends DatasetInfo - Table extends TableInfo - Job extends JobInfo - Update READMEs and snippets - Update BigQueryExample - Update and add more tests

- Make Builder public - Make Dataset.builder package scope - Add toAndFromPb test - Remove static get methods

…r methods from Resource Manager's Project

- Remove static builder methods - Add builder methods params to builder constructors - Better javadoc for builder classes

Make bigquery functional classes extend info classes

Fix the 'Definition of groupId is redundant' mvn warning

Make Table methods public

Make storage functional objects subclasses of metadata objects.

Fix failing bigquery ITs due to missing queryPlan

Site cleanup

Fix NPE in bigquery XXXInfo.equals

- Create a package named after each service in gcloud-java-examples - Create a package snippet in each service's package to hold README's snippets - Split Datastore Storage and ResourceManager examples in two - Create a class for each snippet in the corresponding service package - Add reference for the READMEs to the corresponding snippet class - Update package-info.java accordingly

- Remove check for existence in datastore and storage create snippets - Rename GetOrCreateBlob to CreateBlob, GetOrCreateEntity to CreateEntity - Use relative links in READMEs - Remove full snippets in module's READMEs, replaced with link to class

This is an import of previous work which was reviewed internally.

Also implemented FakeStorageRPC to provide an in-memory GCS implementation for testing (it's not complete yet, but good enough for simple tests).

@aozarov

I also made the following additional changes: - Don't use one-line javadocs, per request of @aozarov - Use public domain John Keats poetry published in 1819 - Minor cleanup to a few JavaDocs

@ajkannan

This change is a follow-up to post-merge comments in googleapis#706 made by @ajkannan and @aozarov. The following changes have been made: - Don't use @nullable on equals() methods - Don't `throws Exception` in test methods unless needed - Use incomplete sentences in JavaDoc summary fragment - Capitalize Cloud Storage - Get rid of some one-line JavaDocs - Use @code formatting when appropriate - Remove Paths.get() usages which is deprecated in Java 8 - Remove @SuppressWarnings("null") which no one uses

googlebot · 2016-03-09T18:55:22Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

aozarov · 2016-03-09T20:41:27Z

@jean-philippe-martin do you mind to fix the conflicts?

jart · 2016-03-09T21:45:34Z

Why are you rebasing? Why not merge master?

jean-philippe-martin · 2016-03-09T22:13:17Z

I think you're right and merging master would be a better thing to do.

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 456641589 Source-Link: googleapis/googleapis@8a251f5 Source-Link: https://github.com/googleapis/googleapis-gen/commit/4ca52a529cf01308d9714950edffbea3560cfbdb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGNhNTJhNTI5Y2YwMTMwOGQ5NzE0OTUwZWRmZmJlYTM1NjBjZmJkYiJ9

) * chore: fix license header in build.bat * chore: add disctribution field for setup-java action Source-Link: googleapis/synthtool@4fea5f4 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:df8d7b2cc0dbc65871e7edd86601901a0612b272fa3f7f0eb590c5c53aa5f92e

🤖 I have created a release *beep* *boop* --- ## [2.3.0](googleapis/java-iot@v2.2.1...v2.3.0) (2022-07-01) ### Features * Enable REST transport for most of Java and Go clients ([googleapis#734](googleapis/java-iot#734)) ([68d152f](googleapis/java-iot@68d152f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…1.0 (#734) * chore(deps): update dependency com.google.cloud:libraries-bom to v26.1.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…ityscanner to v2.2.2 (#734) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-websecurityscanner](https://togithub.com/googleapis/java-websecurityscanner) | `2.2.1` -> `2.2.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-websecurityscanner/2.2.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-websecurityscanner/2.2.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-websecurityscanner/2.2.2/compatibility-slim/2.2.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-websecurityscanner/2.2.2/confidence-slim/2.2.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-websecurityscanner).

…1.1 (#734) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.0` -> `26.1.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/compatibility-slim/26.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/confidence-slim/26.1.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-texttospeech).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google-api-core](https://togithub.com/googleapis/python-api-core) | `==2.8.2` -> `==2.10.2` | [![age](https://badges.renovateapi.com/packages/pypi/google-api-core/2.10.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-api-core/2.10.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-api-core/2.10.2/compatibility-slim/2.8.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-api-core/2.10.2/confidence-slim/2.8.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-notification).

🤖 I have created a release *beep* *boop* --- ## [0.123.19](https://togithub.com/googleapis/java-notification/compare/v0.123.18...v0.123.19) (2022-10-10) ### Dependencies * Update dependency google-api-core to v2.10.2 ([#734](https://togithub.com/googleapis/java-notification/issues/734)) ([ba4213c](https://togithub.com/googleapis/java-notification/commit/ba4213c3971fff904c058446722a924cf083cbaa)) * Update dependency typing-extensions to v4.4.0 ([#733](https://togithub.com/googleapis/java-notification/issues/733)) ([3b3b005](https://togithub.com/googleapis/java-notification/commit/3b3b005235a1fe279cb858da86e72f13f1767d1c)) * Update dependency zipp to v3.9.0 ([#735](https://togithub.com/googleapis/java-notification/issues/735)) ([6e5e3da](https://togithub.com/googleapis/java-notification/commit/6e5e3da762e83e213768692aa44555d88f63b3f9)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore: release 3.4.1-SNAPSHOT * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

mziccard and others added 30 commits February 2, 2016 20:12

Make bigquery functional classes extend info classes

b0c0bb7

- Dataset extends DatasetInfo - Table extends TableInfo - Job extends JobInfo - Update READMEs and snippets - Update BigQueryExample - Update and add more tests

Make functional objects subclasses of metadata objects.

3d1c1c8

Minor refactoring bigquery functional objects

94533b2

- Make Builder public - Make Dataset.builder package scope - Add toAndFromPb test - Remove static get methods

Add functional classes to SerializationTest

5829d81

minor fixes

aa0e377

Add toBuilder tests for Bucket and Blob, remove static get and builde…

6870eb7

…r methods from Resource Manager's Project

Add builder test to increase coverage

75dbbf8

Refactor bigquery function objects builders

b6ad451

- Remove static builder methods - Add builder methods params to builder constructors - Better javadoc for builder classes

Add missing override annotation and serialVersionUID

fbcbfb4

Merge pull request googleapis#609 from mziccard/bigquery-hierachies

4bf3796

Make bigquery functional classes extend info classes

try latest version of coveralls

ae7e62e

Make Table methods public

7761a9e

Fix the 'Definition of groupId is redundant' mvn warning

3ce2cc6

Merge pull request googleapis#622 from mziccard/fix-groupid-warning

f7990c0

Fix the 'Definition of groupId is redundant' mvn warning

Merge pull request googleapis#621 from mziccard/bigquery-hierachies

8ba9230

Make Table methods public

Minor fixes

288c993

Merge pull request googleapis#614 from ajkannan/storage-merge-objects

cdec697

Make storage functional objects subclasses of metadata objects.

Fix failing bigquery ITs due to missing queryPlan

3f39ab2

Merge pull request googleapis#625 from mziccard/master

d2dbd99

Fix failing bigquery ITs due to missing queryPlan

Site cleanup

ef7c74f

Merge pull request googleapis#627 from ajkannan/cleanup-site

2bb9cb0

Site cleanup

Fix NPE in bigquery XXXInfo.equals

f06c11a

Update javadoc in Table definitions (remove type naming)

3502610

Shorten line longer than 100 characters

6955bf4

Merge pull request googleapis#632 from mziccard/bigquery-hierachies

307ddf3

Fix NPE in bigquery XXXInfo.equals

Add comment in snippet classes reminding to update docs upon change

b8b2612

Update example links in module's READMEs

384a3f1

Rename John Do to John Doe

6fed3ee

jart and others added 4 commits March 8, 2016 15:34

Cloud Storage Java 7 nio library

32060ce

This is an import of previous work which was reviewed internally.

Migrated GCS NIO from App Engine to gcloud-storage

c74b6fb

Also implemented FakeStorageRPC to provide an in-memory GCS implementation for testing (it's not complete yet, but good enough for simple tests).

Run google-java-format on GCS NIO

2248848

I also made the following additional changes: - Don't use one-line javadocs, per request of @aozarov - Use public domain John Keats poetry published in 1819 - Minor cleanup to a few JavaDocs

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Mar 9, 2016

jean-philippe-martin mentioned this pull request Mar 9, 2016

Add integration test and example jar. #714

Merged

aozarov added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 9, 2016

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Mar 9, 2016

jean-philippe-martin closed this Mar 9, 2016

suztomo pushed a commit that referenced this pull request Feb 1, 2023

chore(main): release 2.13.1-SNAPSHOT (#734)

0bf2f50

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rebase#734

Rebase#734
jean-philippe-martin wants to merge 128 commits intogoogleapis:gcs-niofrom
jean-philippe-martin:gcs-nio

jean-philippe-martin commented Mar 9, 2016

Uh oh!

googlebot commented Mar 9, 2016

Uh oh!

aozarov commented Mar 9, 2016

Uh oh!

jart commented Mar 9, 2016

Uh oh!

jean-philippe-martin commented Mar 9, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

jean-philippe-martin commented Mar 9, 2016

Uh oh!

googlebot commented Mar 9, 2016

Uh oh!

aozarov commented Mar 9, 2016

Uh oh!

jart commented Mar 9, 2016

Uh oh!

jean-philippe-martin commented Mar 9, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants