feat: servlet classes that use the jakarta namespace#1115
Conversation
meltsufin
left a comment
There was a problem hiding this comment.
Do we need to update any public documentation?
|
@ludoch PTAL |
| * } | ||
| * </pre> | ||
| * | ||
| * @since 1.36.0 |
There was a problem hiding this comment.
1.36.0 is it the real new version that will be pushed? Otherwise, change it (and other files)
There was a problem hiding this comment.
Also curious if you need to configure Kokoro cfg files to enable SBOM generation (here and in all Cloud APIs area?)
There was a problem hiding this comment.
The latest is 1.35.0. This 1.36.0 is the real value to be released.
There was a problem hiding this comment.
Checking SBOM generation.
There was a problem hiding this comment.
Confirmed Kokoro configs are set up (log). Search for sbom.spdx.json.
Yes, I'll update the document (https://developers.google.com/api-client-library/java/google-api-java-client/oauth2#web_server_applications). |
Fixes #2260 Copied the implementation with the jakarta.servlet namespace using the same methology as googleapis/google-oauth-java-client#1115. - Replaced javax with jakarta and declared the dependency with provided scope. - Keeping the classes as `Beta` annotated. - No tests exist for the classes. - Added `@since 2.6.0` as the last release was 2.5.1.
* feat: WebHookUtil classes using the jakarta namespace Fixes #2260 Copied the implementation with the jakarta.servlet namespace using the same methology as googleapis/google-oauth-java-client#1115. - Replaced javax with jakarta and declared the dependency with provided scope. - Keeping the classes as `Beta` annotated. - No tests exist for the classes. - Added `@since 2.6.0` as the last release was 2.5.1. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Fixes #1112, to support the
jakarta.servletnamespace.@since, and copyright year are updated.jakarta.servlet-apiversion 5 is declared as provided dependency. It's 5 (not the latest 6) because this repository is built with Java 8 and version 6 requires Java 11. It's "provided" scope because the servlet API artifacts in general are provided by the runtime (such as AppEngine).