feat: Support gRPC Compression#2197
Merged
yirutang merged 6 commits intogoogleapis:mainfrom Jul 21, 2023
Merged
Conversation
yirutang
reviewed
Jul 20, 2023
Contributor
yirutang
left a comment
There was a problem hiding this comment.
Thanks for getting this fixed!
| Preconditions.checkNotNull(compressorName); | ||
| Preconditions.checkArgument( | ||
| compressorName.equals("gzip"), | ||
| "Compression of type \"%s\" isn't supported, only \"gzip\" compression is supported.", |
Contributor
There was a problem hiding this comment.
Only check it at the bottom layer (ConnectionWorker) is enough?
Contributor
Author
There was a problem hiding this comment.
Removed from JsonStreamWriter and SchemaAwareStreamWriter, and left it in StreamWriter. Verified that it's what we usually do.
...querystorage/src/main/java/com/google/cloud/bigquery/storage/v1/SchemaAwareStreamWriter.java
Outdated
Show resolved
Hide resolved
yirutang
approved these changes
Jul 20, 2023
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
🤖 I have created a release *beep* *boop* --- ## [2.41.0](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.40.1...v2.41.0) (2023-07-24) ### Features * Add enable connection pool to sample ([#2192](https://togithub.com/googleapis/java-bigquerystorage/issues/2192)) ([c2642de](https://togithub.com/googleapis/java-bigquerystorage/commit/c2642de07556381490c92eedf25b17d36218c2f8)) * Support gRPC Compression ([#2197](https://togithub.com/googleapis/java-bigquerystorage/issues/2197)) ([642e345](https://togithub.com/googleapis/java-bigquerystorage/commit/642e3452f3b490d6d85b61dfd1a1bb82e175d565)) ### Bug Fixes * Reduce StreamConnection visibility since it is not supposed to be public. ([#2196](https://togithub.com/googleapis/java-bigquerystorage/issues/2196)) ([addbcdf](https://togithub.com/googleapis/java-bigquerystorage/commit/addbcdf04e330a76e29e41b1e8f4ca04ad96ed00)) * Update SchemaAwareStreamWriter comment to down recommend it. ([#2195](https://togithub.com/googleapis/java-bigquerystorage/issues/2195)) ([4897c05](https://togithub.com/googleapis/java-bigquerystorage/commit/4897c05aeb7cddff20fb530d64034cc143c24d91)) ### Dependencies * Update dependency com.google.cloud:google-cloud-bigquery to v2.30.1 ([#2191](https://togithub.com/googleapis/java-bigquerystorage/issues/2191)) ([da4f2e5](https://togithub.com/googleapis/java-bigquerystorage/commit/da4f2e5e801daad1136eb4a3e753e486cef194e7)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.13.1 ([#2199](https://togithub.com/googleapis/java-bigquerystorage/issues/2199)) ([fc8f4fb](https://togithub.com/googleapis/java-bigquerystorage/commit/fc8f4fbae333db08ae21730a61a8993c3e1f9897)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable gRPC compression when a compressor name is provided to JsonStreamWriter/StreamWriter.
Only
gzipcompression is supported at the moment.Please note that while it will reduce the network usage, it will increase CPU usage. Please verify the trade off per use case.