chore: README.md to be updated by Release Please#1963
Merged
suztomo merged 3 commits intogoogleapis:mainfrom Apr 13, 2023
Merged
chore: README.md to be updated by Release Please#1963suztomo merged 3 commits intogoogleapis:mainfrom
suztomo merged 3 commits intogoogleapis:mainfrom
Conversation
Contributor
|
Use this as a reference: https://github.com/GoogleCloudPlatform/pgadapter/blob/postgresql-dialect/.github/release-please.yml |
|
Warning: This pull request is touching the following templated files:
|
Member
Author
|
The bot says |
suztomo
commented
Apr 13, 2023
Member
Author
|
Good that OwlBot Java Postprocessor didn't revert the change. |
ddixit14
approved these changes
Apr 13, 2023
renovate-bot
pushed a commit
to renovate-bot/java-storage
that referenced
this pull request
Apr 13, 2023
* chore: README.md to be updated by Release Please * extraFiles as the yaml parameter
Member
Author
|
It didn't work.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now java-storage's README.md has
{x-version-update-start:google-cloud-storage:released}. This release please configuration should allow Release Please to update the version in README.md:https://github.com/googleapis/java-storage/blob/main/README.md?plain=1#L39
@ddixit14 Would you review this? Is this all we need to make Release Please update the README.md?