feat: add libraries_bom_version in metadata#1956
Merged
JoeWang1127 merged 9 commits intomasterfrom Apr 15, 2024
Merged
Conversation
Contributor
Author
|
These lines prevent me to write a unit test running in kokoro. |
blakeli0
approved these changes
Apr 15, 2024
JoeWang1127
added a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Apr 16, 2024
In this PR: - Add `libraries_bom_version` as a required parameter in generation config. The integration test is verified using a feature branch of synthtool: googleapis/synthtool#1956. The synthtool commit in integration test is changed to `63cc541da2c45fcfca2136c43e638da1fbae174d` after the above feature branch is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
libraries_bom_versionwhen rendingREADME.md. It will fall back tolatest_bom_versionif this parameter is not set.