Allow unknown limits to be requested with value undefined
#4781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
550680f to
4656c90
Compare
Contributor
|
Previews, as seen when this build job started (3039572): |
This is useful for application code like this:
`{ requiredLimits: { someLimit: adapter.limits.someLimit } }`
in several situations:
- A limit was removed (gpuweb#4688)
- A limit exists in one browser, but another browser doesn't know about it
(though it provides very limited protection against this)
- Possibly, depending on future designs:
a limit is part of a feature, and the feature isn't available (gpuweb#4613)
4656c90 to
cfd2897
Compare
kainino0x
commented
Aug 28, 2024
toji
approved these changes
Aug 28, 2024
Member
toji
left a comment
There was a problem hiding this comment.
LGTM! I think this is a good move for making the API less brittle as it evolves.
juj
added a commit
to juj/wasm_webgpu
that referenced
this pull request
Sep 6, 2024
…s is a nonfunctional change for the wasm bindings. gpuweb/gpuweb#4781
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
Sep 18, 2024
gpuweb/gpuweb@23db3e4...2dc56f2 * Handle device limits being undefined * gpuweb/gpuweb#4781 * Remove the maxInterStageShaderComponents limit * gpuweb/gpuweb#4783 Bug: 368022291 Change-Id: I548a1c2e841aa40feb0234214a9dc75289ffcb13 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/207095 Commit-Queue: Geoff Lang <geofflang@google.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
8 tasks
kainino0x
pushed a commit
to gpuweb/cts
that referenced
this pull request
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal.Accepted!This is useful for application code like this:
{ requiredLimits: { someLimit: adapter.limits.someLimit } }when
adapter.limits.someLimitisundefineddue to situations such as:(though it provides very limited protection against this)
a limit is part of a feature, and the feature isn't available (Define conventions/rules for features that add new limits #4613)