CSS: Don't cache unrecognized CSS property names #2298
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
When writing this patch I discovered that we have no tests that our prefixing mechanism works. :O The commit that introduced them didn't add them: |
3e0a2db to
e816e94
Compare
Member
Author
|
BTW, this both fixes the bug & reduces the size by 1 byte. ;) |
Member
Author
|
I found some issues with this patch, marking as WIP. |
e816e94 to
de39b88
Compare
Member
Author
There was a problem hiding this comment.
Without this change we'd set node.style.undefined; I added a test for that.
Member
Author
|
Should be ready now. -5 bytes. :) |
de39b88 to
25ca2a4
Compare
Member
Author
|
I added one more test. |
Member
Author
There was a problem hiding this comment.
transform is unprefixed in WebKit Nightly but it's prefixed in all Androids < 5 so this should not become a useless test any time soon.
Member
|
LGTM, nice unit test. 😄 |
Member
|
👍 |
This prevents jQuery from caching a prefixed property name if provided directly by the user, e.g. the following code: elem.css( "msTransform", "translate(5px, 2px)" ); should not prevent one from from later setting the transition directly: elem.css( "transform", "translate(5px, 2px)" ); on a browser not understanding the unprefixed version which is the case for Safari 8 & transform. Fixes jquerygh-2015
25ca2a4 to
6da90d9
Compare
Member
Author
|
I'll merge it tomorrow if no one opposes. |
mgol
added a commit
that referenced
this pull request
Jun 1, 2015
This prevents jQuery from caching a prefixed property name if provided directly by the user, e.g. the following code: elem.css( "msTransform", "translate(5px, 2px)" ); should not prevent one from from later setting the transition directly: elem.css( "transform", "translate(5px, 2px)" ); on a browser not understanding the unprefixed version which is the case for Safari 8 & transform. (cherry-picked from d471842) Fixes gh-2015 Closes gh-2298
mgol
added a commit
that referenced
this pull request
Nov 10, 2015
This prevents jQuery from caching a prefixed property name if provided directly by the user, e.g. the following code: elem.css( "msTransform", "translate(5px, 2px)" ); should not prevent one from from later setting the transition directly: elem.css( "transform", "translate(5px, 2px)" ); on a browser not understanding the unprefixed version which is the case for Safari 8 & transform. Fixes gh-2015 Closes gh-2298
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents jQuery from caching a prefixed property name if provided
directly by the user, e.g. the following code:
should not prevent one from from later setting the transition directly:
on a browser not understanding the unprefixed version which is the case
for Safari 8 & transform.
Fixes gh-2015