Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

The committers are authorized under a signed CLA.

• ✅ abubyr (16d121e)

Welcome @abubyr!

It looks like this is your first PR to kubernetes/cloud-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Hi @abubyr. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

I just tried this fix using a cluster that is created every morning for multiple days in a row. It's correctly populating the target groups when first deploying the cloud controller \o/.
With the latest released version, the cloud controller needs to be restarted in order to have the target groups filled.

/ok-to-test

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Hello,

This issue is still happening in 1.24.3 (causing a lot of issues and forcing us to move to CLB which the consequent reduction in the features like the possibility of assigning fixed IPs in the LBs).

Any idea when this merge could get accepted as part of a following release?

This PR has been released. Make sure you run cloud controller manager 1.24.1 or later

@olemarkus There is no 1.24.1 in the Github Releases for this project, only 1.24.0 on 13 May. Is there another place to look for release info?

Edit: Apologies for asking (un-) related project questions, but I see you're active on kOps as well...

How does one instruct kOps 1.24.1 running Kubernetes 1.24.3 to use cloud-provider-aws 1.24.1? Wait for a kOps release?

Try setting something like this

spec:
  cloudControllerManager:
    image:   registry.k8s.io/provider-aws/cloud-controller-manager:v1.24.1

I'll see to this being bumped in kOps shortly.

See kubernetes/kops#14130

I recently came across this and I think I've found the original issue, https://github.com/kubernetes/cloud-provider-aws/pull/293/files#diff-70a4ebdf516a65404dc3c3b3ba9925fc62d0f85bd75e272a4f8ddb4b7b8ab852L620-L623

These lines were dropped, I'm guessing unintentionally and meant that the chunking work also got broken. IMO we should be reverting this PR and reinstating these lines, the end of this block should be like below, as it was originally

		tg := result.TargetGroups[0]
		tgARN := aws.StringValue(tg.TargetGroupArn)
		if err := c.ensureTargetGroupTargets(tgARN, expectedTargets, nil); err != nil {
			return nil, err
		}
		return tg, nil

I created #527 to restore the behaviour and re-separate the create and update behaviours. This will save us some API calls when creating services and re-distinguish the difference between create and update behaviour in the ensureTargetGroups function