Fix sizeof typo in MessageWriter::GetRelativeIndex#40276
Merged
Conversation
0bc67a7 to
036e6a9
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a Linux build break in wsl::shared::MessageWriter::GetRelativeIndex() caused by sizeof(index) binding to the POSIX ::index symbol, and also includes several test/dependency updates related to kernel/9p behavior.
Changes:
- Fix
MessageWriter::GetRelativeIndexto usesizeof(Index)(the function parameter) to restore Linux builds. - Update kernel package version and adjust tests for updated 9p mount option formatting / filesystem behavior.
- Increase mirrored networking stabilization timeout and add richer diagnostics in the mirrored networking tests.
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/shared/inc/message.h |
Fix sizeof(index) typo by referencing the correct Index parameter. |
packages.config |
Update Microsoft.WSL.Kernel package version. |
test/windows/UnitTests.cpp |
Update expected GPU 9p mount options string (cache=0x5). |
test/windows/NetworkTests.cpp |
Add interface-level logging during mirrored-state wait and extend watchdog timeout. |
test/linux/unit_tests/lxtfs.c |
Update expected 9p mount option formatting and adjust writev test expectations. |
test/linux/unit_tests/eventfd.c |
Write/read only the uint64_t payload size for eventfd validation. |
OneBlue
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sizeof(index)incorrectly resolved to a C library function type (::indexfrom<strings.h>) instead of theIndexparameter, causing a build error on Linux:Fix:
sizeof(index)→sizeof(Index)to match the parameter name.Introduced in 58bd525 (#40197).