Fix batch of minor bugs#40197
Merged
chemwolf6922 merged 45 commits intomasterfrom Apr 22, 2026
Merged
Conversation
benhillis
pushed a commit
that referenced
this pull request
Apr 17, 2026
Bugs fixed (not covered by PR #40197): - unittests.c: Fix get_addr_info test entry pointing to wrong handler (GetSetIdTestEntry -> GetAddrInfoTestEntry) - SocketChannel.h: Fix %s format specifier in fmt-style LOG_ERROR on Linux; channel name was silently dropped from protocol error logs - p9file.cpp: Fix readlinkat return type (int -> ssize_t) to match POSIX specification - configfile.cpp: Guard ungetwc() call against WEOF to avoid undefined behavior on some implementations - init.cpp: Fix SIGCHLD race by blocking the signal before setting the handler, preventing a window where child exit could be lost - util.cpp: Extract duplicated signal skip list into SkipSignal() helper to ensure consistency between save and set handlers Test improvements: - NetworkTests.cpp: Add SO_RCVTIMEO timeout on accept() to prevent indefinite test hangs (resolves TODO) - DrvFsTests.cpp: Add LOG_IF_WIN32_BOOL_FALSE to cleanup operations to surface silent file/directory deletion failures Script hardening: - copy_and_build_tests.ps1: Replace Invoke-Expression with call operator to prevent command injection via interpolated variables - test-setup.ps1: Pass PostInstallCommand through bash -c for proper shell argument handling - deploy-to-vm.ps1: Prompt for password via Read-Host -AsSecureString when not provided, instead of creating empty SecureString Resource management: - WslConfigService.cs: Dispose FileSystemWatcher in destructor to prevent resource leak Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
benhillis
pushed a commit
that referenced
this pull request
Apr 17, 2026
Full deep review covering 7 subsystems with 44 findings. 12 fixes on this branch, 10+ already in PR #40197, 4 deferred. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
6 tasks
OneBlue
reviewed
Apr 20, 2026
OneBlue
approved these changes
Apr 21, 2026
benhillis
approved these changes
Apr 21, 2026
benhillis
added a commit
that referenced
this pull request
Apr 22, 2026
sizeof(index) incorrectly resolved to a C library function type instead of the Index parameter, causing a build error on Linux. Fix the casing to match the parameter name. Introduced in 58bd525 (#40197). Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR fixes a batch of minor bugs / issues found during code review.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed