[#131407] Fix service worker version check in browsers #131408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make sure to post the 'version' message to the newly created service worker instead of an old one.
|
|
Collaborator
|
Thanks for looking into this! |
sdissegna-maystreet
added a commit
to sdissegna-maystreet/code-server
that referenced
this pull request
Aug 25, 2021
jsjoeio
added a commit
to coder/code-server
that referenced
this pull request
Aug 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #131407
When a service worker is started, the creator sends a message to verify its version. Sometimes this message was being sent to an older, already existing service worker. As a result, the
workerReadypromise would never resolve and the webview would stay in a loading state.The best way I found to test this was to load a jupyter notebook ("Jupyter: Create New Blank Notebook) in a browser environment (I used https://github.com/cdr/code-server for that) in Firefox. It happens in Chrome too (~10% of the time), but it's more common in Firefox (~50% of the time).