Minimap - highlight all instances of selected word #132584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdima
reviewed
Sep 8, 2021
| stickiness: TrackedRangeStickiness.NeverGrowsWhenTypingAtEdges, | ||
| className: 'selectionHighlight', | ||
| minimap: { | ||
| color: themeColorFromId(minimapFindMatch), |
Member
There was a problem hiding this comment.
I suggest that we create a new color e.g. minimalSelectionHighlight and not reuse minimapFindMatch
alexdima
requested changes
Sep 8, 2021
Member
alexdima
left a comment
There was a problem hiding this comment.
I find it a bit confusing to reuse the minimapFindMatch color for selection highlights. I suggest to define a new color.
|
|
Contributor
Author
|
The color used is the same as in Atom |
… they are also rendered in the overview ruler
… rendering certain decorations in the minimap
alexdima
approved these changes
Sep 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #84151
Adds minimap decoration options that are the same as find decoration ones on double click selection.
To test, simply double click a word after which you will see it selected in the minimap.