Skip to content

add: flow-root for display property completion#29

Closed
praveenpuglia wants to merge 1 commit into
microsoft:masterfrom
praveenpuglia:display-flow-root
Closed

add: flow-root for display property completion#29
praveenpuglia wants to merge 1 commit into
microsoft:masterfrom
praveenpuglia:display-flow-root

Conversation

@praveenpuglia

@praveenpuglia praveenpuglia commented May 16, 2017

Copy link
Copy Markdown
Contributor

flow-root is now a supported value for display which essentially replaces the clearfix hack. It's available in Chrome 58 and FF53 onwards.

It didn't appear in VSCode completion, so I thought I would make a PR here.

@msftclas

Copy link
Copy Markdown

@praveenpuglia,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@aeschli

aeschli commented Jul 4, 2017

Copy link
Copy Markdown
Collaborator

@praveenpuglia Hi Praveen, browsers.js is generated from css-schema.xml. I made your suggested change there, regenerated and pushed. I hope that's ok for you. Thanks for the PR!

@aeschli aeschli closed this Jul 4, 2017
aeschli added a commit that referenced this pull request Jul 4, 2017
@praveenpuglia

Copy link
Copy Markdown
Contributor Author

I didn't know that. Thanks for updating in right place. :)

@praveenpuglia praveenpuglia deleted the display-flow-root branch July 7, 2017 03:46
@aeschli aeschli added this to the July 2017 milestone Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants