Add skip bucket/region/object name validation as special usecase#1576
Merged
harshavardhana merged 2 commits intominio:masterfrom Aug 5, 2024
Merged
Add skip bucket/region/object name validation as special usecase#1576harshavardhana merged 2 commits intominio:masterfrom
harshavardhana merged 2 commits intominio:masterfrom
Conversation
balamurugana
requested changes
Aug 5, 2024
Contributor
Author
|
Thanks for your feedback, adapted it accordingly. |
balamurugana
approved these changes
Aug 5, 2024
harshavardhana
approved these changes
Aug 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
the minio-java client is my preferred way to access S3 buckets within java projects.
Unfortunately in my current project I need to access an on-premises S3 bucket.
For some historic reasons the bucketname contains underscores and as such does not adhere to the official naming rules.
Sadly I have no means to correct this bucketname easily without causing severe efforts throughout the organization.
For this reason I would appreciate to have a possibility to disable the validation in such cases.
With this PR I'd like to propose a feasible solution.
I researched passt issues/change-requests, this might also be related to #1564 .