Use OpenSSL's keylog callback for SSLKEYLOGFILE (#3994) #4298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kriechi
reviewed
Nov 27, 2020
Kriechi
reviewed
Nov 27, 2020
| tls.log_master_secret.close() | ||
| with open(logfile, "rb") as f: | ||
| assert f.read().count(b"CLIENT_RANDOM") >= 2 | ||
| assert f.read().count(b"SERVER_HANDSHAKE_TRAFFIC_SECRET") >= 2 |
Member
There was a problem hiding this comment.
Does this mean the content changed with the new pyopenssl version?
Is Wireshark already compatible with this new format?
Member
Author
There was a problem hiding this comment.
It definitely changed for TLS 1.3, not sure what we'd get for older versions. It doesn't really matter though, the point of the new API is just that: here are some opaque bytes you should save as-is in your keylog file.
And yes, works fine with WireShark, I used this extensively for sans-io :-)
syhe
pushed a commit
to syhe/macports-ports
that referenced
this pull request
May 10, 2021
mitmproxy requires pyOpenSSL>=20.0 since v6.0.0 refs mitmproxy/mitmproxy#4298
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3994, but requires a new pyOpenSSL release to be shipped first. Putting this here because I depend on it for sans-io debugging.